Outbound app enhancement (#537)

* Allow to set outbound app clientSecret in app creation

* lint fix

* add clientSecret to outbound app object

* Allow to set outbound app clientSecret in app creation and update

* revert adding clientSecret to main object

* fix format

Author: talaharoni

lib/management/outboundapplication.test.ts

@@ -55,13 +55,15 @@ describe('Management OutboundApplication', () => {
         await management.outboundApplication.createApplication({
           name: 'name',
           description: 'test',
+          clientSecret: 'shhh..',
         });
 
       expect(mockHttpClient.post).toHaveBeenCalledWith(
         apiPaths.outboundApplication.create,
         {
           name: 'name',
           description: 'test',
+          clientSecret: 'shhh..',
         },
         { token: 'key' },
       );
@@ -92,6 +94,7 @@ describe('Management OutboundApplication', () => {
         name: 'name',
         logo: 'logo',
         description: 'desc',
+        clientSecret: 'shhh..',
       });
 
       expect(mockHttpClient.post).toHaveBeenCalledWith(
@@ -102,6 +105,7 @@ describe('Management OutboundApplication', () => {
             name: 'name',
             logo: 'logo',
             description: 'desc',
+            clientSecret: 'shhh..',
           },
         },
         { token: 'key' },

lib/management/outboundapplication.ts

@@ -15,7 +15,7 @@ type WithOptional<T, K extends keyof T> = Omit<T, K> & Partial<Pick<T, K>>;
 
 const withOutboundApplication = (sdk: CoreSdk, managementKey?: string) => ({
   createApplication: (
-    app: WithOptional<OutboundApplication, 'id'>,
+    app: WithOptional<OutboundApplication, 'id'> & { clientSecret?: string },
   ): Promise<SdkResponse<OutboundApplication>> =>
     transformResponse<OutboundApplicationResponse, OutboundApplication>(
       sdk.httpClient.post(
@@ -27,7 +27,9 @@ const withOutboundApplication = (sdk: CoreSdk, managementKey?: string) => ({
       ),
       (data) => data.app,
     ),
-  updateApplication: (app: OutboundApplication): Promise<SdkResponse<OutboundApplication>> =>
+  updateApplication: (
+    app: OutboundApplication & { clientSecret?: string },
+  ): Promise<SdkResponse<OutboundApplication>> =>
     transformResponse<OutboundApplicationResponse, OutboundApplication>(
       sdk.httpClient.post(
         apiPaths.outboundApplication.update,