Fix common-js build (Breaking Changes) (#437) RELEASE MINOR

* fix rollup

* run build before test

* move build to a step

* readme

Author: asafshen

.github/workflows/ci.yml

@@ -90,8 +90,8 @@ jobs:
           node-version: ${{ env.NODE_VERSION }}
       # Skip post-install scripts here, as a malicious
       # script could steal NODE_AUTH_TOKEN.
-      - name: Install dependencies
-        run: npm ci --ignore-scripts
+      - name: Install dependencies and build
+        run: npm ci --ignore-scripts && npm run build
         env:
           CI: true
           NODE_AUTH_TOKEN: ${{ secrets.CI_NPM_READ_ORG }}

README.md

@@ -89,15 +89,17 @@ Every `async` operation may fail. In case it does, there will be information reg
 A typical case of error handling might look something like:
 
 ```ts
-import { SdkResponse, descopeErrors } from '@descope/node-sdk';
+import DescopeClient, { SdkResponse } from '@descope/node-sdk';
+
+const { DescopeErrors } = DescopeClient;
 
 // ...
 
 try {
   const resp = await sdk.otp.signIn.email(loginId);
   if (resp.error) {
     switch (resp.error.errorCode) {
-      case descopeErrors.userNotFound:
+      case DescopeErrors.userNotFound:
         // Handle specifically
         break;
       default:

lib/commonjs.test.ts

@@ -0,0 +1,14 @@
+// this test requires to run `npm run build` before running the test
+
+describe('commonjs build', () => {
+  it('should default export a function with constants', () => {
+    const DescopeClient = require('../dist/cjs/index.cjs.js') as any; // eslint-disable-line
+    expect(typeof DescopeClient).toBe('function');
+    // should have constants
+    expect(DescopeClient.RefreshTokenCookieName).toBeTruthy();
+    expect(DescopeClient.SessionTokenCookieName).toBeTruthy();
+    expect(DescopeClient.DescopeErrors).toBeTruthy();
+  });
+});
+
+export {}; // eslint-disable-line

lib/index.ts

@@ -15,6 +15,7 @@ import fetch from './fetch-polyfill';
 import { getAuthorizationClaimItems, isUserAssociatedWithTenant, withCookie } from './helpers';
 import withManagement from './management';
 import { AuthenticationInfo } from './types';
+import descopeErrors from './errors';
 
 declare const BUILD_VERSION: string;
 
@@ -371,6 +372,7 @@ const nodeSdk = ({ managementKey, publicKey, ...config }: NodeSdkArgs) => {
 
 nodeSdk.RefreshTokenCookieName = refreshTokenCookieName;
 nodeSdk.SessionTokenCookieName = sessionTokenCookieName;
+nodeSdk.DescopeErrors = descopeErrors;
 
 export default nodeSdk;
 export type {
@@ -380,5 +382,4 @@ export type {
   ResponseData,
   SdkResponse,
 } from '@descope/core-js-sdk';
-export * as descopeErrors from './errors';
 export type { AuthenticationInfo };

rollup.config.js

@@ -34,7 +34,7 @@ export default [
       file: packageJson.main,
       format: 'cjs',
       sourcemap: true,
-      exports: 'auto',
+      exports: 'default',
     },
     plugins,
     external,