Skip to content

Commit d9dcd1e

Browse files
authored
Fix example build and bump dependencies (#169)
* fix example build * this should fix build * expose types
1 parent 69cf631 commit d9dcd1e

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

examples/es6/src/index.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { ResponseData, SdkResponse } from '@descope/core-js-sdk';
2-
import type { DeliveryMethod, OAuthProvider } from '@descope/node-sdk';
1+
import type { DeliveryMethod, OAuthProvider, ResponseData, SdkResponse } from '@descope/node-sdk';
32
import DescopeClient from '@descope/node-sdk';
43
import bodyParser from 'body-parser';
54
import express, { NextFunction, Request, Response } from 'express';
@@ -43,7 +42,7 @@ const authMiddleware = async (req: Request, res: Response, next: NextFunction) =
4342
}
4443
};
4544

46-
const returnOK = <T extends ResponseData>(res: Response, out: SdkResponse<T>) => {
45+
const returnOK = (res: Response, out: SdkResponse<ResponseData>) => {
4746
res.setHeader('Content-Type', 'application/json');
4847
if (!out.ok) {
4948
res.status(400).send(out.error);

examples/es6/tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
"esModuleInterop": true,
1010
"skipLibCheck": true,
1111
"forceConsistentCasingInFileNames": true,
12-
"moduleResolution": "Node"
12+
"moduleResolution": "Node",
13+
"noEmitOnError": true
1314
},
1415
"include": ["src/**/*"]
1516
}

lib/index.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,4 +286,9 @@ nodeSdk.RefreshTokenCookieName = refreshTokenCookieName;
286286
nodeSdk.SessionTokenCookieName = sessionTokenCookieName;
287287

288288
export default nodeSdk;
289-
export type { DeliveryMethod, OAuthProvider } from '@descope/core-js-sdk';
289+
export type {
290+
DeliveryMethod,
291+
OAuthProvider,
292+
ResponseData,
293+
SdkResponse,
294+
} from '@descope/core-js-sdk';

tsconfig.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@
1313
"isolatedModules": true,
1414
"declaration": true,
1515
"declarationDir": "dts",
16-
"typeRoots": ["./node_modules/@types"]
16+
"typeRoots": ["./node_modules/@types"],
17+
"noEmitOnError": true
1718
},
1819

1920
"include": ["lib/**/*.ts"],

0 commit comments

Comments
 (0)