BGS Group Catalog VAC Review (Post-DR1)

[dylanagreen]

Contact Person: Ian Williams
1 catalog file (fits), 1 README

Initial Checks:

• Includes README
• Columns in ALLCAPS
• Extension names in ALLCAPS
• Files include units
• VAC publication passed CWR

Initial Notes:

• Can you please add an extension name to the fits header so that it can be accessed by name and not just index?
• Thanks for including units in your VAC file!
• I'm not seeing anything else jumping out at me at this time, thanks

[ianw89]

I believe I have now addressed this and updated the FITS file on NERSC, @dylanagreen

[dylanagreen]

Thanks @ianw89, this is looking good and I think we can move it to final review @weaverba137

[weaverba137]

We need to finalize the "stub" catalog name for this one, after which I think it is OK to move to staging.

[dylanagreen]

@ianw89 Do you have a preferred stubname for this VAC? The stubname will be used for the README file as well as the on-disk location for the vac (e.g. /dr1/stubname/v1.0/). If not I suggest some variation of bgs-groups.

[dylanagreen]

We've reset this issue and removed it from the DR1 Project to be revisited at a later, post-DR1, VAC release, per the VAC author's request.

[weaverba137]

@dylanagreen, it's now been a year since we last reviewed this VAC. Is this still in progress?

[dylanagreen]

@weaverba137 I never received any further communication from the group, so have no concept of what the status is. @ianw89 is there an update on this VAC?

If we don't hear back within ~1 week I suggest we go ahead and close this issue. If necessary we can always reopen or open a new one at a later date.

[weaverba137]

Thank you for checking @dylanagreen!

[ianw89]

I apologize for not seeing these messages. Work on this VAC has been ongoing. It (obviously) took much longer to wrap up than anticipated. However I now am getting ready for CWR and looking to resume this process. I will place a newer version of the catalog on NERSC shortly.

[weaverba137]

@ianw89, thank you for the update.

[ianw89]

Hello @dylanagreen and @weaverba137 - I have placed a new version of the group catalog in this folder: /global/cfs/cdirs/desi/users/ianw89/groupcatalogs/BGS_Y1/v0.7/

... alongside footprint matched randoms that probably should be released with it (this is because my footprint doesn't exactly match DR 1 BGS). I updated the readme a bit too. If you'd prefer I can copy it over the old location as well.

Looking back over this thread, if we still need a stub name, you can use 'bgs-groups-scgf' for "Self Calibrated Group Finder" maybe?

I will send this to CWR as soon as my collaborators approve, so I thought this might be a good time to check in with you.

[weaverba137]

@ianw89, I will take a look at the files as soon as I can. As long as the new README file is in the new location, we'll just use that one.

Since there are currently no other explicitly-named BGS catalogs, I think bgs-groups would be sufficient.