CIV Absorber VAC Review (Post-DR1 + DR2)

[weaverba137]

Contact Person: Abhijeet Anand, @abhi0395
2 catalog files (fits), 1 README

Initial Checks:

• Includes README
• Columns in ALLCAPS
• Extension names in ALLCAPS
• Files include units
• VAC publication passed CWR

Initial Notes:

• We need a "stub" name and version for this VAC, I suggest "civ-absorber/v1.0". Is this acceptable?
• CIV_healpix-dr1-cat-v1.fits
  • HDU 0 has some non-trivial keywords, so it might be useful to add an EXTNAME to that HDU, e.g. 'PRIMARY'.
  • In HDU METADATA, EFFTIME has units of sec, which is not valid in the FITS standard; s is the correct unit.
• dr1-QSO_healpix_cat_for_CIV_search.fits
  • EXTNAME is not set for any HDU.
  • In HDU 1, EFFTIME has units of seconds, which is not valid in the FITS standard; s is the correct unit.

[abhi0395]

Hi @weaverba137 , thanks so much for your quick review and comments.

• Yes, I am fine with the "stub" and version name. Do I need to change the filename to include v1.0, or that should be fine?
• Thanks for the suggestion, I have added the HDU EXTNAMEs now
• Also, updated the EFFTIME units to s
• README files are also updated accordingly.

Please let me know if this looks good to you.

[weaverba137]

@abhi0395, I think you've satisfied all the comments on the contents of the files.

I have some further comments on the names of the files:

• CIV_healpix-dr1-cat-v1.fits: what purpose does 'healpix' in the name serve? If I may suggest, CIV-absorber-dr1-v1.0.fits would make more sense.
• dr1-QSO_healpix_cat_for_CIV_search.fits is also a bit difficult to understand. CIV-absorber-parent-dr1-v1.0.fits would make more sense to me, i.e. "parent" is the full set of objects that were searched for CIV absorbers.

This would also apply to the dr2 catalogs with just dr1 --> dr2.

[abhi0395]

Thanks @weaverba137!

• I included healpix in the name to highlight that the quasar spectra were selected from healpix-based catalogs, not tile-based ones.
• I see your point, but I wanted to make sure it's clear that these are the parent QSOs that were searched for C IV absorbers — that’s why I included QSO in the filename.
• v1.0 sounds fine to me.

[weaverba137]

You could simply document the 'healpix' selection in the README file, which it might not be right now.

There is nothing wrong with parent-QSO or QSO-parent.

[abhi0395]

Thanks @weaverba137

• I have changed the names as per your suggestion:
  • CIV-Absorbers-dr1-v1.0.fits
  • CIV-Absorbers-parent-QSO-dr1-v1.0.fits
    Same for dr2, updated the README, added healpix details there. Does this look good to you?

[weaverba137]

If you're ready to proceed, I can freeze copies of those files in the VAC staging areas.

After that, the README file needs to be converted into a page in desidatadocs.

[abhi0395]

Thanks @weaverba137
Yes, the files are ready to be frozen.

[weaverba137]

Finalized files have been copied to

$DESI_ROOT/vac/dr1/civ-absorber/v1.0
$DESI_ROOT/vac/dr2/civ-absorber/v1.0

Please take a look.

[abhi0395]

Thanks! I checked, everything looks good to me.

[weaverba137]

The DR1 files are now public. I'll leave this issue open as a reminder to do the same for DR2.

[abhi0395]

Thank you so much.

[weaverba137]

Changing the title as a reminder that the DR2 version of this VAC should be (briefly) re-reviewed just before DR2 becomes public.

[weaverba137]

@abhi0395 in keeping with a recent policy change, VACs are now expected to be included in the publication CWR process. If your publication has already been through CWR, please go ahead and check the "VAC publication passed CWR" box above.