Restore original regex global flag use

Including the flag in the original, shared regex requires resetting
`lastIndex` after each use. You'll get unexpected results otherwise.
Also fixes all failing tests for `getLinks()`.

Author: 11k

Diff for: lib/chat-utils/link-regex.js

@@ -1427,5 +1427,5 @@ const scheme = '(https?|ftp|wss?)://';
 const strict = `\\b${scheme}${pathCont}`;
 const relaxed = `${strict}|${webURL}`;
 
-const linkRegex = new RegExp(relaxed, 'gi');
+const linkRegex = new RegExp(relaxed, 'i');
 module.exports = linkRegex;

Diff for: lib/services/message-matching.js

@@ -6,7 +6,7 @@ module.exports = {
   },
   getLinks(message) {
     return Array.from(
-      message.matchAll(linkRegex),
+      message.matchAll(new RegExp(linkRegex, 'g')),
       (k) => (k[0].startsWith('http') ? k[0] : `http://${k[0]}`), // add protocol to link
     )
       .map((link) => {