Fix triggering spam if mention twice and then don't mention.

Mitchdev · Mitchdev · commit e900c93792c6 · 2024-01-27T20:55:41.000+13:00
diff --git a/lib/message-routing/message-router.js b/lib/message-routing/message-router.js
@@ -109,6 +109,7 @@ class MessageRouter {
       this.spamDetection.checkListOfRecentUrlsForSpam(
         messageContent,
         this.chatCache.getViewerUrlList(user),
+        this.chatCache.messageUrlSpamUser,
       ),
     ];
 
diff --git a/lib/services/spam-detection.js b/lib/services/spam-detection.js
@@ -118,7 +118,8 @@ class SpamDetection {
     return this.isSimilarityAboveThreshold(matchPercents);
   }
 
-  checkListOfRecentUrlsForSpam(message, urlList) {
+  checkListOfRecentUrlsForSpam(message, urlList, mentionUser = null) {
+    if (mentionUser && !this.messageMatching.mentionsUser(message, mentionUser)) return false;
     return this.messageMatching.getLinks(message).some((link) => {
       return (
         urlList.filter((url) => url === link.hostname + link.pathname).length >=

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,8 @@ class SpamDetection {`
`118`	`118`	`return this.isSimilarityAboveThreshold(matchPercents);`
`119`	`119`	`}`
`120`	`120`
`121`		`- checkListOfRecentUrlsForSpam(message, urlList) {`
	`121`	`+ checkListOfRecentUrlsForSpam(message, urlList, mentionUser = null) {`
	`122`	`+ if (mentionUser && !this.messageMatching.mentionsUser(message, mentionUser)) return false;`
`122`	`123`	`return this.messageMatching.getLinks(message).some((link) => {`
`123`	`124`	`return (`
`124`	`125`	`urlList.filter((url) => url === link.hostname + link.pathname).length >=`