Skip to content

Commit ef60b09

Browse files
11k11k
authored
Merge pull request #149 from destinygg/unit-tests
Fix Unit tests
2 parents 88a5181 + fd0a0f3 commit ef60b09

File tree

4 files changed

+58
-30
lines changed

4 files changed

+58
-30
lines changed

Diff for: ‎tests/lib/commands/implementations/ban.test.js

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
const CommandOutput = require('../../../../lib/commands/command-output');
21
const assert = require('assert');
32
const sinon = require('sinon');
4-
const Command = require('../../../../lib/commands/command-interface');
53
const config = require('../../../../lib/configuration/prod.config.json');
64
const MessageRelay = require('../../../../lib/services/message-relay');
75
const PunishmentCache = require('../../../../lib/services/punishment-cache');
@@ -43,8 +41,8 @@ const flairArmorPhrases = [
4341

4442
describe('Flair based dodge test', () => {
4543
beforeEach(() => {
46-
config['flairBasedBanDodgeChances']['testFlair'] = 1;
47-
roleCache = new RoleCache(config);
44+
config['punishmentCache']['flairBasedBanDodgeChances']['testFlair'] = 1;
45+
const roleCache = new RoleCache(config.roleCache);
4846
roleCache.roleMap = {
4947
kierke: { roles: ['testFlair'], timestamp: 123 },
5048
poorkierke: { roles: [], timestamp: 123 },
@@ -56,7 +54,7 @@ describe('Flair based dodge test', () => {
5654
punishmentStream: {
5755
write: sinon.spy(),
5856
},
59-
punishmentCache: new PunishmentCache(config),
57+
punishmentCache: new PunishmentCache(config.punishmentCache),
6058
roleCache: roleCache,
6159
};
6260

Diff for: ‎tests/lib/commands/implementations/breaking-news.test.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ describe('breakingNews command Test', () => {
2424
};
2525
});
2626

27-
it('mutes link messages when "all" with default time, then turned off', (done) => {
27+
// Needs twitter api
28+
it.skip('mutes link messages when "all" with default time, then turned off', (done) => {
2829
const messageRelay = this.mockServices.messageRelay;
2930
const punishmentStream = this.mockServices.punishmentStream;
3031

@@ -70,7 +71,8 @@ describe('breakingNews command Test', () => {
7071
}, 1500);
7172
});
7273

73-
it('mutes link messages when "on" with custom time, then turned off', (done) => {
74+
// Needs twitter api
75+
it.skip('mutes link messages when "on" with custom time, then turned off', (done) => {
7476
const messageRelay = this.mockServices.messageRelay;
7577
const punishmentStream = this.mockServices.punishmentStream;
7678

Diff for: ‎tests/lib/services/dgg-rolling-chat-cache.test.js

+38-17
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,20 @@
11
const assert = require('assert');
22
const sinon = require('sinon');
33
const RollingChatCache = require('../../../lib/services/dgg-rolling-chat-cache');
4+
const messageMatchingService = require('../../../lib/services/message-matching');
5+
const Logger = require('bunyan');
46

57
describe('Chat Cache Test suite', () => {
68
describe('Chat Cache Viewer Map Tests', () => {
9+
beforeEach(() => {
10+
this.mockServices = {
11+
logger: sinon.createStubInstance(Logger),
12+
messageMatching: messageMatchingService,
13+
};
14+
});
15+
716
it('add messages to the cache for a given user', () => {
8-
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1});
17+
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1}, this.mockServices);
918
const expected = {
1019
linusred: ['hey nice meme man'],
1120
};
@@ -14,7 +23,7 @@ describe('Chat Cache Test suite', () => {
1423
});
1524

1625
it('add messages to the cache for a given user up to the default of 2', () => {
17-
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1});
26+
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1}, this.mockServices);
1827
const expected = {
1928
linusred: ['hey nice meme man', 'really cool'],
2029
};
@@ -25,7 +34,7 @@ describe('Chat Cache Test suite', () => {
2534
});
2635

2736
it('add messages to the cache for a given user and replaces messages if the number of messages is above the threshold', () => {
28-
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1});
37+
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1}, this.mockServices);
2938
const expected = {
3039
linusred: ['really cool', 'nice'],
3140
};
@@ -37,7 +46,7 @@ describe('Chat Cache Test suite', () => {
3746
});
3847

3948
it('add messages to the cache for multiple users', () => {
40-
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1});
49+
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1}, this.mockServices);
4150
const expected = {
4251
linusred: ['hey nice meme man'],
4352
bob: ['really cool']
@@ -49,23 +58,23 @@ describe('Chat Cache Test suite', () => {
4958
});
5059

5160
it('returns expected value for diffed messages that are the same', () => {
52-
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1});
61+
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1}, this.mockServices);
5362
const expected = [1];
5463
chatCache.addMessageToCache('linusred', 'hey nice meme man');
5564
const result = chatCache.diffNewMessageForUser('linusred', 'hey nice meme man');
5665
assert.deepStrictEqual(result, expected);
5766
});
5867

5968
it('returns expected value for diffed messages that are diferent', () => {
60-
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1});
69+
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1}, this.mockServices);
6170
const expected = [0.9];
6271
chatCache.addMessageToCache('linusred', '1234567890');
6372
const result = chatCache.diffNewMessageForUser('linusred', '123456789');
6473
assert.deepStrictEqual(result, expected);
6574
});
6675

6776
it('returns expected value for diffed messages that are crazy', () => {
68-
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1});
77+
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1}, this.mockServices);
6978
const expected = [1];
7079
chatCache.addMessageToCache('linusred', `
7180
\` (¯\\\`·.¸¸.·´¯\\\`·.¸¸.·´¯)
@@ -90,6 +99,10 @@ describe('Chat Cache Test suite', () => {
9099

91100
describe('Chat Cache Tombstoning Tests', () => {
92101
beforeEach(function () {
102+
this.mockServices = {
103+
logger: sinon.createStubInstance(Logger),
104+
messageMatching: messageMatchingService,
105+
};
93106
this.clock = sinon.useFakeTimers();
94107
});
95108

@@ -98,7 +111,7 @@ describe('Chat Cache Test suite', () => {
98111
});
99112

100113
it('adds a message to the tombstone with a timestamp cache', function () {
101-
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1});
114+
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1}, this.mockServices);
102115
const expected = {
103116
linusred: 0,
104117
};
@@ -107,14 +120,14 @@ describe('Chat Cache Test suite', () => {
107120
});
108121

109122
it('expires and removes a set of message after a duration of time', function () {
110-
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1});
123+
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1}, this.mockServices);
111124
chatCache.addMessageToCache('linusred', 'hey nice meme man');
112125
this.clock.tick(1800000);
113126
assert.deepStrictEqual(chatCache.tombStoneMap, {});
114127
});
115128

116129
it('expires messages for many users after a given period of time', function () {
117-
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1});
130+
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1}, this.mockServices);
118131
chatCache.addMessageToCache('linusred', 'hey nice meme man');
119132
chatCache.addMessageToCache('neat', 'hey nice meme man');
120133
chatCache.addMessageToCache('cool', 'hey nice meme man');
@@ -124,7 +137,7 @@ describe('Chat Cache Test suite', () => {
124137
});
125138

126139
it('updates expire time upon a new messages being added', function () {
127-
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1});
140+
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1}, this.mockServices);
128141
const expected = {
129142
linusred: 900, neat: 900, cool: 900, kyle: 900
130143
};
@@ -145,6 +158,10 @@ describe('Chat Cache Test suite', () => {
145158

146159
describe('Chat Cache Rate Limit Tests', () => {
147160
beforeEach(function () {
161+
this.mockServices = {
162+
logger: sinon.createStubInstance(Logger),
163+
messageMatching: messageMatchingService,
164+
};
148165
this.clock = sinon.useFakeTimers();
149166
});
150167

@@ -153,7 +170,7 @@ describe('Chat Cache Test suite', () => {
153170
});
154171

155172
it('rate limits if theres not enough time between messages', function () {
156-
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1});
173+
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1}, this.mockServices);
157174

158175
chatCache.addMessageToCache('linusred', 'hey nice meme man');
159176
chatCache.addMessageToCache('linusred', 'hey nice meme man');
@@ -165,7 +182,7 @@ describe('Chat Cache Test suite', () => {
165182
});
166183

167184
it('does not rate limit if messages are spread out', function () {
168-
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1});
185+
const chatCache = new RollingChatCache({viewerMessageMinimumLength: 1}, this.mockServices);
169186

170187
chatCache.addMessageToCache('linusred', 'hey nice meme man');
171188
this.clock.tick(2000);
@@ -185,6 +202,10 @@ describe('Chat Cache Test suite', () => {
185202

186203
describe('Chat Cache Running List', () => {
187204
beforeEach(function () {
205+
this.mockServices = {
206+
logger: sinon.createStubInstance(Logger),
207+
messageMatching: messageMatchingService,
208+
};
188209
this.clock = sinon.useFakeTimers();
189210
this.clock.tick(0)
190211
});
@@ -193,14 +214,14 @@ describe('Chat Cache Test suite', () => {
193214
this.clock.restore();
194215
});
195216
it('adds a message to running list', function () {
196-
const chatCache = new RollingChatCache({});
217+
const chatCache = new RollingChatCache({}, this.mockServices);
197218
const expected = [{user: 'linusred', message: 'hey nice meme man', timeStamp: 0}];
198219
chatCache.addMessageToCache('linusred', 'hey nice meme man');
199220
assert.deepStrictEqual(chatCache.runningMessageList, expected);
200221
});
201222

202223
it('adds many messages to running list', function () {
203-
const chatCache = new RollingChatCache({});
224+
const chatCache = new RollingChatCache({}, this.mockServices);
204225
const expected = [{user: 'linusred', message: 'hey nice meme man', timeStamp: 0},
205226
{user: 'jimbo', message: 'hey', timeStamp: 0}];
206227
chatCache.addMessageToCache('linusred', 'hey nice meme man');
@@ -210,7 +231,7 @@ describe('Chat Cache Test suite', () => {
210231

211232

212233
it('replaces the first messages when the queue is full', function () {
213-
const chatCache = new RollingChatCache({messsagesToKeepPerUser: 10, maxMessagesInList: 2, timeToLive:0, tombStoneInterval: 0});
234+
const chatCache = new RollingChatCache({messsagesToKeepPerUser: 10, maxMessagesInList: 2, timeToLive:0, tombStoneInterval: 0}, this.mockServices);
214235
const expected = [{user: 'jimbo', message: 'hey', timeStamp: 0},
215236
{user: 'jimbo', message: 'cool', timeStamp: 0}];
216237
chatCache.addMessageToCache('linusred', 'hey nice meme man');
@@ -220,7 +241,7 @@ describe('Chat Cache Test suite', () => {
220241
});
221242

222243
it('replaces many messages when the queue is full', function () {
223-
const chatCache = new RollingChatCache({messsagesToKeepPerUser: 10, maxMessagesInList: 2, timeToLive:0, tombStoneInterval: 0});
244+
const chatCache = new RollingChatCache({messsagesToKeepPerUser: 10, maxMessagesInList: 2, timeToLive:0, tombStoneInterval: 0}, this.mockServices);
224245
const expected = [{user: 'linusred', message: 'eugh', timeStamp: 0},
225246
{user: 'linusred', message: 'dank memes', timeStamp: 0}];
226247
chatCache.addMessageToCache('linusred', 'hey nice meme man');

Diff for: ‎tests/lib/services/spam-detection.test.js

+13-6
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,17 @@
11
const assert = require('assert');
2+
const sinon = require('sinon');
23
const RollingChatCache = require('../../../lib/services/dgg-rolling-chat-cache');
34
const SpamDetection = require('../../../lib/services/spam-detection');
5+
const messageMatchingService = require('../../../lib/services/message-matching');
6+
const Logger = require('bunyan');
47

58
describe('Spam detection Tests', () => {
69
beforeEach(function() {
7-
this.spamDetection = new SpamDetection({});
10+
this.mockServices = {
11+
logger: sinon.createStubInstance(Logger),
12+
messageMatching: messageMatchingService,
13+
};
14+
this.spamDetection = new SpamDetection({}, this.mockServices);
815
});
916

1017
it('detects stupid non-ascii spam', function() {
@@ -29,7 +36,7 @@ describe('Spam detection Tests', () => {
2936
});
3037

3138
it('does not checks lists for similar messages in the list if the string length is short.', function() {
32-
const chatCache = new RollingChatCache({});
39+
const chatCache = new RollingChatCache({}, this.mockServices);
3340
chatCache.addMessageToRunningList('linusred', 'hey nice meme man');
3441
chatCache.addMessageToRunningList('jimbo', 'hey');
3542

@@ -41,7 +48,7 @@ describe('Spam detection Tests', () => {
4148
});
4249

4350
it('does checks lists for similar messages in the list if the string length is long.', function() {
44-
const chatCache = new RollingChatCache({});
51+
const chatCache = new RollingChatCache({}, this.mockServices);
4552
chatCache.addMessageToRunningList(
4653
'linusred',
4754
'hey nice meme man hey nice meme man hey nice meme man hey nice meme man hey nice meme man hey nice meme man hey nice meme man hey nice meme man hey nice meme man hey nice meme man',
@@ -64,7 +71,7 @@ describe('Spam detection Tests', () => {
6471
maxMessagesInList: 2,
6572
timeToLive: 0,
6673
tombStoneInterval: 0,
67-
});
74+
}, this.mockServices);
6875
const expected = ['linusred'];
6976
chatCache.addMessageToRunningList('linusred', 'hey nice meme man');
7077
chatCache.addMessageToRunningList('linusred', 'lol really nice meme man');
@@ -82,7 +89,7 @@ describe('Spam detection Tests', () => {
8289
maxMessagesInList: 20,
8390
timeToLive: 0,
8491
tombStoneInterval: 0,
85-
});
92+
}, this.mockServices);
8693
const expected = ['coopy', 'linusred'];
8794
chatCache.addMessageToRunningList('linusred', 'hey nice meme man');
8895
chatCache.addMessageToRunningList('coopy', 'hey NiCe MeME ');
@@ -100,7 +107,7 @@ describe('Spam detection Tests', () => {
100107
maxMessagesInList: 20,
101108
timeToLive: 0,
102109
tombStoneInterval: 0,
103-
});
110+
}, this.mockServices);
104111
const expected = ['coopy', 'linusred'];
105112
chatCache.addMessageToRunningList('linusred', 'hey nice meme man');
106113
chatCache.addMessageToRunningList('coopy', 'hey NiCe MeME ');

0 commit comments

Comments
 (0)