Skip to content

Commit 8c234e1

Browse files
committed
fix(blog): PR 리뷰와 품질 게이트 오류 해소
1 parent 70f5446 commit 8c234e1

3 files changed

Lines changed: 15 additions & 2 deletions

File tree

styles/globals.css

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,17 @@
6363
.ark-site-footer {
6464
grid-column: 1;
6565
grid-row: 1;
66+
position: sticky;
67+
top: 2.5rem;
68+
height: calc(100dvh - 5rem);
6669
align-self: end;
6770
}
6871

72+
.ark-site-footer .ark-site-external-links {
73+
height: 100%;
74+
justify-content: flex-end;
75+
}
76+
6977
.ark-home-statement {
7078
max-width: 34rem;
7179
margin: 0;

styles/globals.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ describe('globals styles', () => {
6464

6565
it('uses a compact single-column mobile shell and article entry scale', () => {
6666
expect(mobileViewportContent).toContain(
67-
"grid-template-areas:\n 'identity'\n 'navigation'\n 'content';"
67+
"grid-template-areas:\n 'identity'\n 'navigation'\n 'content'\n 'footer';"
6868
);
6969
expect(globalsContent).toContain('.ark-article-title {');
7070
expect(globalsContent).toContain('font-size: var(--text-article-title);');

styles/viewport/mobile.css

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@
4141

4242
.ark-site-footer {
4343
grid-area: footer;
44+
position: static;
45+
height: auto;
4446
}
4547

4648
.ark-site-navigation {
@@ -88,7 +90,6 @@
8890
justify-self: start;
8991
gap: 0;
9092
margin-top: 0;
91-
margin-bottom: var(--space-8);
9293
}
9394

9495
.ark-site-grid[data-page-layout='home'] .ark-site-footer {
@@ -127,6 +128,10 @@
127128
padding-bottom: var(--space-2);
128129
}
129130

131+
.ark-site-grid[data-page-layout='content'] .ark-site-footer .ark-site-external-links {
132+
height: auto;
133+
}
134+
130135
.ark-site-grid[data-page-layout='content'] .ark-site-external-links {
131136
flex-direction: row;
132137
justify-content: center;

0 commit comments

Comments
 (0)