fix(blog): 한글 글 경로와 모바일 쉘 정렬 수정 - #123
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70f5446f91
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .ark-site-footer { | ||
| grid-column: 1; | ||
| grid-row: 1; | ||
| align-self: end; |
There was a problem hiding this comment.
On content pages at widths of 640px and above, the footer shares row 1 with the article, so align-self: end places GitHub/Email/RSS at the bottom of the entire article-sized grid row. For long posts, the links therefore disappear from the desktop identity rail until the reader reaches the end, whereas the previous links were inside the viewport-height sticky identity element. Keep the footer sticky or otherwise preserve the prior desktop rail placement while applying the footer layout only on mobile.
AGENTS.md reference: AGENTS.md:L94-L95
Useful? React with 👍 / 👎.
| .ark-site-grid[data-page-layout='home'] .ark-site-footer { | ||
| grid-area: external; | ||
| align-self: end; | ||
| justify-self: start; | ||
| margin-bottom: var(--space-8); |
There was a problem hiding this comment.
On the mobile home layout, .ark-site-external-links still has margin-bottom: var(--space-8) while its new grid-item footer receives the same margin here. Because a grid item's margins do not collapse with its child's margin, the external links are shifted upward by 4rem instead of the previous 2rem, changing the home layout even though this change is intended to preserve it. Apply the bottom spacing to only the wrapper or the links.
AGENTS.md reference: AGENTS.md:L94-L95
Useful? React with 👍 / 👎.
| 'content' | ||
| 'footer'; |
There was a problem hiding this comment.
Adding the footer row here leaves styles/globals.test.ts:66-68 asserting the previous three-row declaration ending in 'content';. Running npm run test:unit -- styles/globals.test.ts now fails deterministically at that assertion, so the repository's full unit suite and test:ci cannot pass until the regression test is updated to reflect the intentional fourth row.
AGENTS.md reference: AGENTS.md:L74-L76
Useful? React with 👍 / 👎.
1 participant
변경 내용
검증
npm run test:unit -- blog/services/post-repository.test.ts site/shell/AppShell/AppShell.test.tsxnpm run lint:css:syntaxnpm run buildgit diff --check