Add unit test for _get_resource_ids method in SCSClusterStatusChecker

Author: devanshjainms

tests/modules/get_cluster_status_scs_test.py

@@ -25,10 +25,47 @@ def scs_checker(self):
         """
         return SCSClusterStatusChecker(sap_sid="TST", ansible_os_family="REDHAT")
 
-    def test_process_node_attributes(self, scs_checker):
+    def test_get_resource_ids(self, mocker, scs_checker):
+        """
+        Test the _get_resource_ids method to ensure ASCS and ERS resource IDs are
+        correctly identified.
+
+        :param mocker: Mocking library to patch methods.
+        :type mocker: pytest_mock.MockerFixture
+        :param scs_checker: Instance of SCSClusterStatusChecker.
+        :type scs_checker: SCSClusterStatusChecker
+        """
+        mock_resources_xml = """
+        <resources>
+            <primitive id="rsc_sap_TST_ASCS00" type="SAPInstance">
+                <instance_attributes>
+                    <nvpair name="IS_ERS" value="false"/>
+                </instance_attributes>
+            </primitive>
+            <primitive id="rsc_sap_TST_ERS01" type="SAPInstance">
+                <instance_attributes>
+                    <nvpair name="IS_ERS" value="true"/>
+                </instance_attributes>
+            </primitive>
+        </resources>
+        """
+
+        mocker.patch.object(
+            scs_checker,
+            "execute_command_subprocess",
+            return_value=mock_resources_xml,
+        )
+
+        scs_checker._get_resource_ids()
+        assert scs_checker.ascs_resource_id == "rsc_sap_TST_ASCS00"
+        assert scs_checker.ers_resource_id == "rsc_sap_TST_ERS01"
+
+    def test_process_node_attributes(self, mocker, scs_checker):
         """
         Test processing node attributes to identify ASCS and ERS nodes.
 
+        :param mocker: Mocker fixture for mocking functions.
+        :type mocker: pytest_mock.MockerFixture
         :param scs_checker: Instance of SCSClusterStatusChecker.
         :type scs_checker: SCSClusterStatusChecker
         """
@@ -52,6 +89,8 @@ def test_process_node_attributes(self, scs_checker):
             </node_attributes>
         </dummy>
         """
+        scs_checker.ascs_resource_id = "rsc_sap_TST_ASCS00"
+        scs_checker.ers_resource_id = "rsc_sap_TST_ERS01"
         node_attributes = ET.fromstring(xml_str)
 
         scs_checker._process_node_attributes(node_attributes)
@@ -83,6 +122,8 @@ def test_process_node_attributes_incomplete(self, scs_checker):
             </node_attributes>
         </dummy>
         """
+        scs_checker.ascs_resource_id = "rsc_sap_TST_ASCS00"
+        scs_checker.ers_resource_id = "rsc_sap_TST_ERS01"
         node_attributes = ET.fromstring(xml_str)
 
         scs_checker._process_node_attributes(node_attributes)

tests/modules/get_pcmk_properties_db_test.py

@@ -112,9 +112,13 @@
     "CRM_CONFIG_DEFAULTS": {"stonith-enabled": "true"},
     "RESOURCE_DEFAULTS": {
         "REDHAT": {
-            "stonith": {
-                "meta_attributes": {"priority": "10"},
-                "operations": {"monitor": {"timeout": "30"}},
+            "fence_agent": {
+                "meta_attributes": {"pcmk_delay_max": "15"},
+                "operations": {"monitor": {"timeout": ["700", "700s"]}},
+            },
+            "sbd_stonith": {
+                "meta_attributes": {"pcmk_delay_max": "15"},
+                "operations": {"monitor": {"timeout": ["30", "30s"]}},
             },
             "hana": {"meta_attributes": {"clone-max": "2"}},
         }

tests/modules/log_parser_test.py

@@ -156,3 +156,62 @@ def exit_json(self, **kwargs):
             monkey_patch.setattr("src.modules.log_parser.AnsibleModule", MockAnsibleModule)
             main()
             assert mock_result["status"] == "FAILED"
+
+    def test_merge_logs_success(self, log_parser_redhat):
+        """
+        Test the merge_logs method for successful log merging.
+
+        :param log_parser_redhat: LogParser instance.
+        :type log_parser_redhat: LogParser
+        """
+        log_parser_redhat.logs = [
+            '["Jan 01 12:34:56 server1 pacemaker-controld: Notice: '
+            'Resource SAPHana_HDB_00 started"]',
+            '["Jan 01 12:35:00 server2 pacemaker-controld: Notice: '
+            'Resource SAPHana_HDB_01 started"]',
+            '["Jan 01 12:36:00 server3 pacemaker-controld: Notice: '
+            'Resource SAPHana_HDB_02 started"]',
+        ]
+
+        log_parser_redhat.merge_logs()
+        result = log_parser_redhat.get_result()
+
+        filtered_logs = [log.strip() for log in json.loads(result["filtered_logs"])]
+        assert len(filtered_logs) == len(log_parser_redhat.logs)
+        assert result["status"] == "PASSED"
+
+    def test_merge_logs_empty_input(self, log_parser_redhat):
+        """
+        Test the merge_logs method with empty input.
+
+        :param log_parser_redhat: LogParser instance.
+        :type log_parser_redhat: LogParser
+        """
+        log_parser_redhat.logs = []
+
+        log_parser_redhat.merge_logs()
+        result = log_parser_redhat.get_result()
+
+        assert json.loads(result["filtered_logs"]) == []
+        assert result["status"] == "PASSED"
+        assert result["message"] == "No logs provided to merge"
+
+    def test_merge_logs_invalid_json(self, log_parser_redhat):
+        """
+        Test the merge_logs method with invalid JSON strings.
+
+        :param log_parser_redhat: LogParser instance.
+        :type log_parser_redhat: LogParser
+        """
+        log_parser_redhat.logs = [
+            '["Jan 01 12:34:56 server1 pacemaker-controld: Notice: '
+            'Resource SAPHana_HDB_00 started"]',
+            "Invalid JSON string",
+        ]
+
+        log_parser_redhat.merge_logs()
+        result = log_parser_redhat.get_result()
+
+        filtered_logs = [log.strip() for log in json.loads(result["filtered_logs"])]
+        assert len(filtered_logs) == 2
+        assert result["status"] == "PASSED"