Skip to content

Commit 4572f0c

Browse files
committed
Add missing nfs_provider parameter to Ansible module and improve task description formatting
1 parent 60dbee1 commit 4572f0c

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

tests/roles/ha_scs/kill_sapstartsrv_test.py

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ def test_environment(self, ansible_inventory):
5555
role_type="ha_scs",
5656
ansible_inventory=ansible_inventory,
5757
task_name="kill-sapstartsrv-process",
58-
task_description="The SAP startsrv Process Kill test simulates failure of the sapstartsrv process",
58+
task_description="The SAP startsrv Process Kill test simulates "
59+
+ "failure of the sapstartsrv process",
5960
module_names=[
6061
"project/library/get_cluster_status_scs",
6162
"project/library/log_parser",
@@ -67,6 +68,16 @@ def test_environment(self, ansible_inventory):
6768
extra_vars_override={"node_tier": "scs"},
6869
)
6970

71+
playbook_content = self.file_operations(
72+
operation="read",
73+
file_path=f"{temp_dir}/project/roles/ha_scs/tasks/kill-sapstartsrv-process.yml",
74+
)
75+
self.file_operations(
76+
operation="write",
77+
file_path=f"{temp_dir}/project/roles/ha_scs/tasks/kill-sapstartsrv-process.yml",
78+
content=playbook_content.replace("set -o pipefail &&", ""),
79+
)
80+
7081
yield temp_dir
7182
shutil.rmtree(temp_dir)
7283

tests/roles/mock_data/get_pcmk_properties_scs.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ def main():
1010
ansible_os_family=dict(type='str', required=True),
1111
virtual_machine_name=dict(type='str', required=True),
1212
pcmk_constants=dict(type='dict', required=True),
13-
fencing_mechanism=dict(type='str', required=True)
13+
fencing_mechanism=dict(type='str', required=True),
14+
nfs_provider=dict(type='str', required=True)
1415
)
1516
)
1617

0 commit comments

Comments
 (0)