workspaceMount support --volumes-from

[Brantfang]

I have a image (include docker cli, node, git and @devcontainers/cli).
when I run this image (docker run --it -v /var/run/docker.sock:/var/run/docker.sock imageName) and use git inside to download the development container.
Next, use the @devcontainers/cli to start the development container (devcontainer up --workspace-folder ) and find that the development container cannot mount the development directory in the current container.
What is the solution to mounting the development directory in the current container in a development container？
I can mount a volume in the current container and then use git to download the development directory to the volume. Then when running devcontainer up, let the dev container --volume-from the current container's volume?how to do？

[samruddhikhandale]

Hi 👋

Thanks for requesting support for --volume-from, it makes sense to me.

If you are interested, feel free to contribute a cli PR with the changes, we appreciate support from the community. Thanks!

// cc @chrmarti

[chrmarti]

"runArgs": ["--volumes-from", "<container name>"] might already work.

[Brantfang]

@chrmarti Thanks，It runs successfully and puts the working directory in the volume, but the default mount uses bind mode to mount the directory (devcontainer up --workspace-folder). Since this working directory is in the container it is not possible to use bind mode. I don't know how to cancel the default mounting method, except to change the mount type to volume in the config file (devcontainer.json), ("workspaceMount": "source=vscode-remote-try-rust,target=/abc,type=volume") .
How can I undo the default behavior since the working directory is already placed in the volume (--volumes-from)?
By the way if you override the default behavior by using the above volume mount method in the config file, do not set the mount target to the same directory when using "runArgs": ["--volumes-from=from-cotainer"], this will result in a failure to mount correctly.

[chrmarti]

@chrmarti You can remove the default with "workspaceMount": "".

[Brantfang]

You can remove the default with "workspaceMount": "".
@chrmarti nice, right way.
Another issue is that when I mounted the original container's volume with --volume-from, the started container discovered that it also mounted docker.sock (which is not a volume and should not be mounted). Is it the default propagation behavior of devcontainer? Because the docker cli was used in the original container and mounted the external docker.sock.

[chrmarti]

The docker-outside-of-docker feature would mount that socket automatically, are you adding that in your devcontainer.json? (Would --volume-from bring that over?)

[Brantfang]

The docker-outside-of-docker feature would mount that socket automatically, are you adding that in your devcontainer.json? (Would --volume-from bring that over?)

@chrmarti Not used docker-outside-of-docker feature. In this issue，I have a custom image based on docker cli with node, @devcontainers/cli and git installed in it (dockercli:node-git).
I want to create development containers in that container (environmentally isolated), so I hooked docker.sock into that container (docker run -it -v /var/run/docker.sock:/var/run/docker.sock dockercli:node-git).

[chrmarti]

I assume this is the default behavior of --volume-from.