From a22ba598b331975d10c630592717f43bfe5c75f8 Mon Sep 17 00:00:00 2001 From: Christof Marti Date: Mon, 6 Jan 2025 11:39:03 +0100 Subject: [PATCH] Do not use build contexts with Podman and Compose (microsoft/vscode-remote-release#10178) --- src/spec-node/containerFeatures.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/spec-node/containerFeatures.ts b/src/spec-node/containerFeatures.ts index 85835557b..d3b3d9269 100644 --- a/src/spec-node/containerFeatures.ts +++ b/src/spec-node/containerFeatures.ts @@ -232,7 +232,9 @@ async function getFeaturesBuildOptions(params: DockerResolverParameters, devCont // TODO generate an image name that is specific to this dev container? const buildKitVersionParsed = params.buildKitVersion?.versionMatch ? parseVersion(params.buildKitVersion.versionMatch) : undefined; const minRequiredVersion = [0, 8, 0]; - const useBuildKitBuildContexts = buildKitVersionParsed ? !isEarlierVersion(buildKitVersionParsed, minRequiredVersion) : false; + const useBuildKitBuildContexts = params.isPodman + ? !('dockerComposeFile' in devContainerConfig.config) // https://github.com/microsoft/vscode-remote-release/issues/10178#issuecomment-2330257443 + : buildKitVersionParsed ? !isEarlierVersion(buildKitVersionParsed, minRequiredVersion) : false; const buildContentImageName = 'dev_container_feature_content_temp'; const isBuildah = !!params.buildKitVersion?.versionString.toLowerCase().includes('buildah');