Improve error printing

[kylebarron]

I was talking with @vincentsarago and he mentioned he got an error that looked like:

GenericError: Generic {
    store: "S3",
    source: BareRedirect,
}

Looking at the upstream implementation I see

/// Retry request error
#[derive(Debug, thiserror::Error)]
pub enum Error {
    #[error("Received redirect without LOCATION, this normally indicates an incorrectly configured region")]
    BareRedirect,

Perhaps we should update our errors to use the to_string impl? Note that this was previously changed in #54 https://github.com/developmentseed/obstore/blame/78860c6e71255bdf06c973b9b9435cdedc2e3fdd/pyo3-object_store/src/error.rs#L112

[gadomski]

👍🏼 just ran into this, and the region hint helped me fix.

[kylebarron]

Can you test with @weiji14 's change?

[gadomski]

Yup, much nicer. Before:

pyo3_object_store.GenericError: Generic {
    store: "S3",
    source: ListRequest {
        source: BareRedirect,
    },
}

With the fix in #272:

pyo3_object_store.GenericError: Generic S3 error: Error performing list request: Received redirect without LOCATION, this normally indicates an incorrectly configured region

🚢

[kylebarron]

The tough part is that it's hard to follow the entire error chain. So especially the lower level errors, like those coming from reqwest (apache/arrow-rs-object-store#48) get swallowed up. So without the debug formatting, timeout errors are super obscure. They just print error decoding response body.

So now with #322 it'll print both the display and debug error output.

GenericError: Generic S3 error: Error performing list request: Error performing GET https://s3.us-east-1.amazonaws.com/sentinel-cogs?&list-type=2 in 114.172458ms - Received redirect without LOCATION, this normally indicates an incorrectly configured region

Debug source:
Generic {
    store: "S3",
    source: ListRequest {
        source: RetryError {
            method: GET,
            uri: Some(
                https://s3.us-east-1.amazonaws.com/sentinel-cogs?&list-type=2,
            ),
            retries: 0,
            max_retries: 10,
            elapsed: 114.172458ms,
            retry_timeout: 180s,
            inner: BareRedirect,
        },
    },
}