Skip to content

Commit 0c95025

Browse files
authored
Update PR template and CODEOWNERS (#1625)
* Update PR template and CODEOWNERS Signed-off-by: Jordan Dubrick <[email protected]> * add devspaces owners Signed-off-by: Jordan Dubrick <[email protected]> --------- Signed-off-by: Jordan Dubrick <[email protected]>
1 parent b10e979 commit 0c95025

File tree

2 files changed

+21
-15
lines changed

2 files changed

+21
-15
lines changed

.github/CODEOWNERS

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# Global Owners
2-
* @amisevsk @yangcao77 @johnmcollier
2+
* @AObuchow @dkwon17 @devfile/devfile-services-team

.github/PULL_REQUEST_TEMPLATE.md

+20-14
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,20 @@
1-
## What does this PR do?
1+
# Description of Changes
2+
_Summarize the changes you made as part of this pull request._
23

3-
<!-- _Summarize the changes_ -->
4+
# Related Issue(s)
5+
_Link the GitHub/GitLab/JIRA issues that are related to this PR._
46

5-
### Which issue(s) does this PR fix
7+
# Acceptance Criteria
8+
<!-- _Check the relevant boxes below_ -->
9+
_Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation._
610

7-
<!-- _Link to github issue(s)_ -->
11+
New testing and documentation issues can be opened under [`devfile/api/issues`](https://github.com/devfile/api/issues).
812

9-
### PR acceptance criteria
13+
You can check the respective criteria below if either of the following is true:
14+
- There is a separate tracking issue opened and that issue is linked in this PR.
15+
- Testing/documentation updates are contained within this PR.
1016

11-
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
12-
13-
> - Open new test/doc issues under the [devfile/api](https://github.com/devfile/api/issues) repo
14-
> - Check each criteria if:
15-
> - There is a separate tracking issue. Add the issue link under the criteria
16-
> **or**
17-
> - test/doc updates are made as part of this PR
18-
> - If unchecked, explain why it's not needed
17+
If criteria is left unchecked please provide an explanation why.
1918

2019
- [ ] Unit/Functional tests
2120

@@ -33,4 +32,11 @@ Testing and documentation do not need to be complete in order for this PR to be
3332

3433
<!-- _Do we have anything that can break our clients? If so, open a notifying issue_ -->
3534

36-
### How to test changes / Special notes to the reviewer
35+
# Tests Performed
36+
_Explain what tests you personally ran to ensure the changes are functioning as expected._
37+
38+
# How To Test
39+
_Instructions for the reviewer on how to test your changes._
40+
41+
# Notes To Reviewer
42+
_Any notes you would like to include for the reviewer._

0 commit comments

Comments
 (0)