Skip to content

spacing_symbols may actually contain exprs rather than symbols #1524

Open
@FabioLuporini

Description

this map may actually be an {expr: float} map rather than a {symbol: float} map. Reproducer is test_dimension.py::TestConditionalDimension::test_subsampled_fd. The ConditionalDimension's spacing is a Mul between its factor and the parent's spacing.

This inconsistency forced me to add an AttributeException here and raise a warning

I did try to fix it, but after 10 mins I was still unsure about what to do, maybe it's obvious to you @mloubout or we can talk about it

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions