refactor: rename workflow store surface

Refs #209

Author: devkade

autoresearch.sh

@@ -302,15 +302,15 @@ function runtimeAutoresearchProbe() {
     import { access, mkdtemp, rm } from "node:fs/promises";
     import os from "node:os";
     import path from "node:path";
-    import { FileKapiStore } from "./src/adapters/file-store.ts";
+    import { FileWorkflowStore } from "./src/adapters/file-store.ts";
     import { KapiService } from "./src/application/workflow-service.ts";
     async function exists(file) {
       try { await access(file); return true; } catch { return false; }
     }
     async function main() {
       const workspace = await mkdtemp(path.join(os.tmpdir(), "kapi-runtime-autoresearch-"));
       try {
-        const service = new KapiService(new FileKapiStore());
+        const service = new KapiService(new FileWorkflowStore());
         const result = await service.startWorkflow({ workspace, workflowId: "kapi-autoresearch", slug: "runtime-contract", task: "Optimize a metric" });
         const names = new Set(result.state.artifacts.map((artifact) => artifact.name));
         const requiredNames = ["state.json", "events.jsonl", "snapshot.json", "contract.md", "benchmark.sh", "checks.sh", "ledger.jsonl", "ideas.md"];
@@ -343,7 +343,7 @@ function runtimeModeProbe(workflowId) {
     import { access, mkdtemp, readFile, rm } from "node:fs/promises";
     import os from "node:os";
     import path from "node:path";
-    import { FileKapiStore } from "./src/adapters/file-store.ts";
+    import { FileWorkflowStore } from "./src/adapters/file-store.ts";
     import { KapiService } from "./src/application/workflow-service.ts";
     async function exists(file) { try { await access(file); return true; } catch { return false; } }
     async function parseJsonFile(file) { try { JSON.parse(await readFile(file, "utf8")); return true; } catch { return false; } }
@@ -359,7 +359,7 @@ function runtimeModeProbe(workflowId) {
     async function main() {
       const workspace = await mkdtemp(path.join(os.tmpdir(), "kapi-runtime-mode-"));
       try {
-        const service = new KapiService(new FileKapiStore());
+        const service = new KapiService(new FileWorkflowStore());
         const result = await service.startWorkflow({ workspace, workflowId: ${JSON.stringify(workflowId)}, slug: "runtime-contract", task: "Probe runtime contract" });
         const filesPass = (await Promise.all(result.state.artifacts.map((artifact) => exists(artifact.path)))).every(Boolean);
         const rootPass = result.state.artifactRoot.includes(".ilchul/workflows/");

docs/product-name-audit.md

@@ -21,7 +21,7 @@ git grep -n -i -E 'kapi|ilchul' -- ':!package-lock.json' ':!node_modules'
 | Storage/config | `.ilchul`, `~/.ilchul`, `.kapi` historical references, and `ILCHUL_*` environment variables appear in docs/tests/runtime setup. | storage/config namespace | `.ilchul` is active storage; `.kapi` is legacy evidence only and must not be deleted by this issue. |
 | GitHub review integration | `kapi-agent`, `kapi-agent/review`, and `kapi-review` remain literal external integration names. | external integration | Keep literal names while the GitHub App and required checks use them. |
 | Documentation/history | README, policy docs, references, and historical explanations still mention Kapi and Ilchul. | documentation/history | New public runtime examples should use `ilchul`; internal implementation examples may use `runctl` / `runtime`; historical and compatibility prose may keep product names with context. |
-| Core/domain/application identifiers | The registry entry type now uses `WorkflowRegistryEntry`; exported classes such as `KapiService` and `KapiStore` remain product-prefixed. The local factory export is now `createLocalWorkflowService`. | known reusable-code leakage reduced by bounded slices | Follow-up slices should rename remaining service/store identifiers by boundary (`WorkflowService`, `WorkflowStore`, etc.) with compatibility exports where safe. |
+| Core/domain/application identifiers | The registry entry type now uses `WorkflowRegistryEntry`; the store interface/class now use `WorkflowStore` / `FileWorkflowStore`; exported service class `KapiService` remains product-prefixed. The local factory export is now `createLocalWorkflowService`. | known reusable-code leakage reduced by bounded slices | Follow-up slices should rename the remaining service identifier by boundary (`WorkflowService`) with compatibility exports where safe. |
 | Application service filenames | The service implementation and factory now use semantic filenames: `src/application/workflow-service.ts` and `src/adapters/workflow-service-factory.ts`. | internal semantic implementation | Keep imports on the semantic service paths; exported class/function names are intentionally left for a smaller follow-up compatibility slice. |
 | CLI worker/runtime helper filenames | Worker event, runtime observation, and GitHub issue context helpers now use semantic filenames: `src/cli/worker-events.ts`, `src/cli/worker-runtime.ts`, and `src/cli/github-issue-context.ts`. | internal semantic implementation | Keep imports on the semantic helper paths; remaining worker event payload names such as `kapi.worker.*` are external event contracts, not filenames. |
 
@@ -35,6 +35,7 @@ git grep -n -i -E 'kapi|ilchul' -- ':!package-lock.json' ':!node_modules'
 - Presentation helper exports use semantic workflow/tool names for generic helpers (`WorkflowToolDefinition`, `shouldBlockWorkflowToolCall`, `formatWorkflowError`).
 - PR review state helpers use generic pull-request / agent-review names (`PullRequestReviewState`, `PullRequestReviewView`, `latestAgentReview`, `reviewCheckConclusion`).
 - Registry entry types now use the semantic `WorkflowRegistryEntry` name across the domain, adapter, CLI, presentation, and tests.
+- Store abstractions now use semantic `WorkflowStore` / `FileWorkflowStore` names across application ports, adapters, and runtime probe scripts; a temporary compatibility export keeps existing tests and external imports working for follow-up slices.
 
 ## Residual scan after service filename rename
 

src/adapters/file-store.ts

@@ -1,4 +1,4 @@
-import type { KapiStore } from "../application/ports.js";
+import type { WorkflowStore } from "../application/ports.js";
 import { workflowDocumentState } from "../application/state-artifacts.js";
 import type { WorkflowState } from "../domain/types.js";
 import { fs, isNotFoundError, path, withNotFoundFallback } from "./fs-path.js";
@@ -10,7 +10,7 @@ interface ActiveIndex {
   updatedAt: string;
 }
 
-export class FileKapiStore implements KapiStore {
+export class FileWorkflowStore implements WorkflowStore {
   async saveWorkflow(state: WorkflowState): Promise<void> {
     const file = path.join(state.artifactRoot, "state.json");
     await this.prepareWritableKapiFile(state.workspace, file);
@@ -388,3 +388,5 @@ export class FileKapiStore implements KapiStore {
     return `# specs/\n\nKapi workflow: ${state.command}\nTask: ${state.task}\nStatus: ${state.status}\nPhase: ${state.phase}\nUpdated: ${state.updatedAt}\n\nRalph-specific specs live in this directory. The generic Kapi artifact API intentionally rejects artifact names with path separators, so specs are tracked through the required \`specs\` directory artifact and concrete files under \`specs/*\`.\n`;
   }
 }
+
+export { FileWorkflowStore as FileKapiStore };

src/adapters/workflow-service-factory.ts

@@ -1,6 +1,6 @@
 import { KapiService } from "../application/workflow-service.js";
 import { ChildRpcDeepInterviewReviewer } from "./deep-interview-child-rpc.js";
-import { FileKapiStore } from "./file-store.js";
+import { FileWorkflowStore } from "./file-store.js";
 import { FileProjectContextProvider } from "./project-context.js";
 import { LocalWorkerCapabilityProvider, LocalWorkerWorkspacePreparer } from "./worker-substrate.js";
 
@@ -9,7 +9,7 @@ export function createLocalWorkflowService(): KapiService {
   const workerAdapters = [workerSubstrate, workerSubstrate, workerSubstrate, workerSubstrate] as const;
   const deepInterviewReviewer = process.env.KAPI_DEEP_INTERVIEW_JUDGE === "child-rpc" ? new ChildRpcDeepInterviewReviewer() : undefined;
   return new KapiService(
-    new FileKapiStore(),
+    new FileWorkflowStore(),
     undefined,
     new FileProjectContextProvider(),
     new LocalWorkerCapabilityProvider(),

src/application/ports.ts

@@ -8,7 +8,7 @@ export interface WorkerCapability {
   reason?: string;
 }
 
-export interface KapiStore {
+export interface WorkflowStore {
   saveWorkflow(state: WorkflowState): Promise<void>;
   loadWorkflow(workspace: string, workflowId: WorkflowId, slug: string): Promise<WorkflowState | undefined>;
   loadActive(workspace: string): Promise<WorkflowState | undefined>;

src/application/workflow-service.ts

@@ -4,7 +4,7 @@ import { unsafeArtifacts, validateHandoffDocument, validateProgressDocument, wit
 import { AUTHORED_METADATA_ARTIFACTS, syncAuthoredArtifactMetadata } from "./authored-artifact-metadata.js";
 import { scanAutoresearchAntiGaming, type AntiGamingFlag } from "./autoresearch-loop.js";
 import { validateExperimentContract } from "./autoresearch-contract.js";
-import type { Clock, CompleteWorkflowInput, DispatchWorkerTaskInput, EvidenceInput, FailWorkflowInput, KapiStore, PlanWorkerInput, PlannedWorkerStrategy, PrepareWorkerInput, ProjectContextProvider, ReadArtifactInput, RefreshWorkerStatusInput, StartWorkflowInput, UpdateWorkflowInput, WorkerCapability, WorkerCapabilityProvider, WorkerKind, WorkerMonitor, WorkerPrepareResult, WorkerStatusSnapshot, WorkerTaskDispatcher, WorkerTaskDispatchResult, WorkerWorkspaceCloser, WorkerWorkspacePreparer, WriteArtifactInput, WriteArtifactsInput } from "./ports.js";
+import type { Clock, CompleteWorkflowInput, DispatchWorkerTaskInput, EvidenceInput, FailWorkflowInput, WorkflowStore, PlanWorkerInput, PlannedWorkerStrategy, PrepareWorkerInput, ProjectContextProvider, ReadArtifactInput, RefreshWorkerStatusInput, StartWorkflowInput, UpdateWorkflowInput, WorkerCapability, WorkerCapabilityProvider, WorkerKind, WorkerMonitor, WorkerPrepareResult, WorkerStatusSnapshot, WorkerTaskDispatcher, WorkerTaskDispatchResult, WorkerWorkspaceCloser, WorkerWorkspacePreparer, WriteArtifactInput, WriteArtifactsInput } from "./ports.js";
 import { EmptyProjectContextProvider, EmptyWorkerCapabilityProvider, SystemClock } from "./service-defaults.js";
 import { addEvidence, assertCompletionEvidence, compactGeneratedSlug, createWorkflowState, getWorkflowDefinition, isTerminalStatus, planWorkerStrategy, renderRunContractPrompt, slugify, transitionWorkflow, validateWorkflowState, WORKFLOW_DEFINITIONS, type WorkflowDefinition, type WorkflowId, type WorkflowState, type WorkflowTransitionRequest, type WorkflowValidationReport } from "./service-domain.js";
 import { buildDeepInterviewSnapshot } from "./deep-interview/snapshot.js";
@@ -19,7 +19,7 @@ const execFileAsync = promisify(execFile);
 
 export class KapiService {
   constructor(
-    private readonly store: KapiStore,
+    private readonly store: WorkflowStore,
     private readonly clock: Clock = new SystemClock(),
     private readonly projectContext: ProjectContextProvider = new EmptyProjectContextProvider(),
     private readonly workers: WorkerCapabilityProvider = new EmptyWorkerCapabilityProvider(),