Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

Solve completeness issue regarding closed contexts or applications exiting #18

@benjivesterby

Description

@benjivesterby

When a context is closed the current implementation will exit out of all logging without draining the channel first. This can cause logs to be lost because they are not pulled prior to exiting.

Each channel should be monitored using something like len of the channel to ensure that all logs are drained prior to exiting the logger. Obviously, this doesn't solve the case where the application is closed, but perhaps an option should be added to monitor for an os signal and drain remaining logs when that happens.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions