Skip to content

Commit ee06e41

Browse files
authored
fix: app overview panic for helm app (#5863)
* fix app overview panic * else if instead of if
1 parent 7b8bac7 commit ee06e41

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

api/appStore/InstalledAppRestHandler.go

+7
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,13 @@ func (handler *InstalledAppRestHandlerImpl) FetchAppOverview(w http.ResponseWrit
148148
token := r.Header.Get("token")
149149
handler.Logger.Infow("request payload, FindAppOverview", "installedAppId", installedAppId)
150150
installedApp, err := handler.installedAppService.GetInstalledAppById(installedAppId)
151+
if err != nil && err != pg.ErrNoRows {
152+
common.WriteJsonResp(w, err, nil, http.StatusInternalServerError)
153+
return
154+
} else if err == pg.ErrNoRows || installedApp == nil {
155+
common.WriteJsonResp(w, errors.New("helm app doses not exist"), nil, http.StatusNotFound)
156+
return
157+
}
151158
appOverview, err := handler.appCrudOperationService.GetAppMetaInfo(installedApp.AppId, installedAppId, installedApp.EnvironmentId)
152159
if err != nil {
153160
handler.Logger.Errorw("service err, FetchAppOverview", "err", err, "appId", installedApp.AppId, "installedAppId", installedAppId)

0 commit comments

Comments
 (0)