Merge pull request #178 from devtron-labs/fix-wrong-ci-status-main

fix: fix for wrong ci status for node eviction cases

Author: gireesh-naidu

kubewatch/pkg/informer/cluster/systemExec/helper.go

@@ -169,11 +169,6 @@ func (impl *InformerImpl) inferFailedReason(eventType string, pod *coreV1.Pod) (
 		}
 		t := ctr.State.Terminated
 		if t == nil {
-			// We should never get here
-			impl.logger.Warnf("Pod %s phase was Failed but %s did not have terminated state", pod.Name, ctr.Name)
-			continue
-		}
-		if t.ExitCode == 0 {
 			// Note: We should never get here
 			// If we do, it means the pod phase is 'Failed' but the main container state is not in 'terminated' state,
 
@@ -193,6 +188,10 @@ func (impl *InformerImpl) inferFailedReason(eventType string, pod *coreV1.Pod) (
 			continue
 		}
 
+		if t.ExitCode == 0 {
+			continue
+		}
+
 		msg := fmt.Sprintf("%s (exit code %d)", t.Reason, t.ExitCode)
 		if t.Message != "" {
 			msg = fmt.Sprintf("%s: %s", msg, t.Message)