Skip to content

Commit 9286358

Browse files
committed
Use PrimitiveType as parameter dictionary value type
1 parent 78e7f99 commit 9286358

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

Sources/Umbrella/RuntimeProviderType.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public extension RuntimeProviderType {
3535
}
3636
}
3737

38-
func log(_ eventName: String, parameters: [String: Any]?) {
38+
func log(_ eventName: String, parameters: [String: PrimitiveType]?) {
3939
guard self.responds else { return }
4040
if let instance = self.instance {
4141
_ = instance.perform(self.selector, with: eventName, with: parameters)

Sources/Umbrella/Umbrella.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@ public protocol AnalyticsType {
55
}
66

77
public protocol ProviderType {
8-
func log(_ eventName: String, parameters: [String: Any]?)
8+
func log(_ eventName: String, parameters: [String: PrimitiveType]?)
99
}
1010

1111
public protocol EventType {
1212
func name(for provider: ProviderType) -> String?
13-
func parameters(for provider: ProviderType) -> [String: Any]?
13+
func parameters(for provider: ProviderType) -> [String: PrimitiveType]?
1414
}
1515

1616
open class Analytics<Event: EventType>: AnalyticsType {

Tests/UmbrellaTests/Fixtures.swift

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import Umbrella
2+
import Foundation
23

34
enum TestEvent: EventType {
45
case login(username: String)
@@ -24,7 +25,7 @@ enum TestEvent: EventType {
2425
}
2526
}
2627

27-
func parameters(for provider: ProviderType) -> [String : Any]? {
28+
func parameters(for provider: ProviderType) -> [String: PrimitiveType]? {
2829
switch self {
2930
case let .login(username):
3031
switch provider {
@@ -46,9 +47,9 @@ enum TestEvent: EventType {
4647
}
4748

4849
class MockProvider: ProviderType {
49-
var events: [(name: String, parameters: [String: Any]?)] = []
50+
var events: [(name: String, parameters: [String: PrimitiveType]?)] = []
5051

51-
func log(_ eventName: String, parameters: [String: Any]?) {
52+
func log(_ eventName: String, parameters: [String: PrimitiveType]?) {
5253
self.events.append((name: eventName, parameters: parameters))
5354
}
5455
}

0 commit comments

Comments
 (0)