Minor oddity in storage.Connector

[candlerb]

I noticed something odd in storage/storage.go

type Connector struct {
...
        // Config holds all the configuration information specific to the connector type. Since there
        // no generic struct we can use for this purpose, it is stored as a byte stream.
        Config []byte `json:"email"`
                             ^^^^^
}

Connector config is stored in a field called "email" ?!

However this was introduced in 8c9c251 (April 2017), so it's been around for a long time and can't be doing any harm :-)

[candlerb]

As a side note: I believe the reason it works is because cmd/dex/config.go defines its own Connector structure used to instantiate StaticConnectors defined in the YAML config. I don't know where or if the tags on storage.Connector would be used.