Skip to content

Commit 048334a

Browse files
committed
Bugfix private ids fail on upsert (by code review)
1 parent b4190f8 commit 048334a

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

addons/dexie-cloud/src/middlewares/createImplicitPropSetterMiddleware.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,9 @@ export function createImplicitPropSetterMiddleware(
7373
// for them - so that server knows when a private ID has been deleted on server
7474
// not accept insert/upserts on them.
7575
if (req.type === 'put') {
76-
const now = Date.now();
7776
delete req.criteria;
7877
delete req.changeSpec;
79-
delete req.updates;
78+
if (!req.upsert) delete req.updates;
8079
obj.$ts = Date.now();
8180
}
8281
}

addons/dexie-cloud/src/middlewares/createMutationTrackingMiddleware.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -334,13 +334,13 @@ export function createMutationTrackingMiddleware({
334334
userId,
335335
values,
336336
}
337-
: upsert ? {
337+
: upsert && updates ? {
338338
type: 'upsert',
339339
ts,
340340
opNo,
341341
keys,
342342
values,
343-
changeSpecs: updates!.changeSpecs.filter((_, idx) => !failures[idx]),
343+
changeSpecs: updates.changeSpecs.filter((_, idx) => !failures[idx]),
344344
txid,
345345
userId,
346346
}

0 commit comments

Comments
 (0)