Skip to content

Commit c3a91cf

Browse files
skip on reinstall + changelog
1 parent d3c7faf commit c3a91cf

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Unreleased
22

3+
* feat: check for Candid incompatibility when upgrading a canister
34
* feat: Init/call arg files now support raw binary without conversion to hex
45
* feat!: Remove argument type inference in init/call args in commands and manifest. Args are always assumed Candid, new parameters allow specifying other formats like hex, and alternate parameters are used to specify loading from a file.
56
* feat: Network gateway now supports a `domains` key

crates/icp-cli/src/operations/install.rs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -185,12 +185,7 @@ pub(crate) async fn install_canister(
185185
};
186186

187187
// Candid interface compatibility check for upgrades and reinstalls
188-
if !yes
189-
&& matches!(
190-
install_mode,
191-
CanisterInstallMode::Upgrade(_) | CanisterInstallMode::Reinstall
192-
)
193-
{
188+
if !yes && matches!(install_mode, CanisterInstallMode::Upgrade(_)) {
194189
match check_candid_compatibility(agent, canister_id, wasm).await {
195190
CandidCompatibility::Compatible => {}
196191
CandidCompatibility::Incompatible(details) => {

0 commit comments

Comments
 (0)