GH review changes

Author: Llorenç

src/frontend/src/lib/flows/recoverWithPhraseFlow.svelte.ts

@@ -30,11 +30,11 @@ const authenticateWithRecoveryPhrase = async (
 };
 
 const bufferEqual = (buf1: ArrayBuffer, buf2: ArrayBuffer): boolean => {
-  if (buf1.byteLength != buf2.byteLength) return false;
+  if (buf1.byteLength !== buf2.byteLength) return false;
   const dv1 = new Int8Array(buf1);
   const dv2 = new Int8Array(buf2);
-  for (let i = 0; i != buf1.byteLength; i++) {
-    if (dv1[i] != dv2[i]) return false;
+  for (let i = 0; i !== buf1.byteLength; i++) {
+    if (dv1[i] !== dv2[i]) return false;
   }
   return true;
 };
@@ -79,7 +79,7 @@ export const recoverWithPhrase = async (
     });
     // Make call to lookup endpoint
     const identityInfo = await anonymousActor.identity_info
-      .withOptions({ agent })(BigInt(userNumber))
+      .withOptions({ agent })(userNumber)
       .then(throwCanisterError);
     return {
       success: true,

src/frontend/src/lib/utils/recoveryPhrase.test.ts

@@ -9,7 +9,7 @@ type TestVector = {
   derivationPath?: number[];
 };
 
-// Test vectors consist of taken from
+// Test vectors are taken from
 // https://github.com/satoshilabs/slips/blob/master/slip-0010.md
 // The public key vectors contained a leading 0-byte for no obvious reason.
 // These were removed.

src/frontend/src/routes/(new-styling)/recovery-phrase/+page.svelte

@@ -10,6 +10,9 @@
     Array.from({ length: 24 }, () => ({ value: "" })),
   );
 
+  // Flag to prevent double-triggering recovery on multiple blur events
+  let recoveryInProgress = $state(false);
+
   // TODO: Use word validation instead of presence.
   const submitEnabled = $derived(
     words.every((word) => word.value.trim().length > 0),
@@ -36,13 +39,26 @@
   };
 
   const handleRecoverWithPhrase = async () => {
+    if (recoveryInProgress) {
+      return;
+    }
+    recoveryInProgress = true;
+
     const phraseWords = words.map((word) => word.value);
-    const result = await recoverWithPhrase(phraseWords);
-    // TODO: Handle success and error
-    if (result.success) {
-      console.log("success", result.info);
-    } else {
-      console.log("error", result.error);
+    try {
+      const result = await recoverWithPhrase(phraseWords);
+      // TODO: Handle success and error
+      if (result.success) {
+        console.log("success", result.info);
+      } else {
+        console.log("error", result.error);
+      }
+    } catch (error) {
+      // TODO: Manage error
+      console.error("error", error);
+    } finally {
+      // Reset flag on error to allow retry
+      recoveryInProgress = false;
     }
   };
 
@@ -53,8 +69,9 @@
     const pastedText = event.clipboardData?.getData("text");
     if (!pastedText) return;
 
-    // Fill inputs starting from current index
-    const pastedWords = pastedText.split(" ");
+    // Uses might paste text with multiple spaces, tabs, or newlines between words.
+    const pastedWords = pastedText.trim().split(/\s+/);
+    // Fill inputs starting from current index.
     pastedWords.forEach((word, i) => {
       const targetIndex = currentIndex + i;
       if (targetIndex < words.length) {
@@ -85,7 +102,7 @@
 
   const handleBlur = () => {
     // Auto-submit when all 24 words are complete
-    if (submitEnabled) {
+    if (submitEnabled && !recoveryInProgress) {
       handleRecoverWithPhrase();
     }
   };