Add canister flag to enable open id generic in frontend (#3296)

* Add canister flag to enable open id generic in frontend

* Add it to feature flags

Author: Llorenç Muntaner

src/frontend/src/lib/generated/internet_identity_idl.js

@@ -55,6 +55,7 @@ export const idlFactory = ({ IDL }) => {
     'archive_config' : IDL.Opt(ArchiveConfig),
     'canister_creation_cycles_cost' : IDL.Opt(IDL.Nat64),
     'analytics_config' : IDL.Opt(IDL.Opt(AnalyticsConfig)),
+    'feature_flag_enable_generic_open_id_fe' : IDL.Opt(IDL.Bool),
     'related_origins' : IDL.Opt(IDL.Vec(IDL.Text)),
     'feature_flag_continue_from_another_device' : IDL.Opt(IDL.Bool),
     'openid_configs' : IDL.Opt(IDL.Vec(OpenIdConfig)),
@@ -850,6 +851,7 @@ export const init = ({ IDL }) => {
     'archive_config' : IDL.Opt(ArchiveConfig),
     'canister_creation_cycles_cost' : IDL.Opt(IDL.Nat64),
     'analytics_config' : IDL.Opt(IDL.Opt(AnalyticsConfig)),
+    'feature_flag_enable_generic_open_id_fe' : IDL.Opt(IDL.Bool),
     'related_origins' : IDL.Opt(IDL.Vec(IDL.Text)),
     'feature_flag_continue_from_another_device' : IDL.Opt(IDL.Bool),
     'openid_configs' : IDL.Opt(IDL.Vec(OpenIdConfig)),

src/frontend/src/lib/generated/internet_identity_types.d.ts

@@ -279,6 +279,7 @@ export interface InternetIdentityInit {
   'archive_config' : [] | [ArchiveConfig],
   'canister_creation_cycles_cost' : [] | [bigint],
   'analytics_config' : [] | [[] | [AnalyticsConfig]],
+  'feature_flag_enable_generic_open_id_fe' : [] | [boolean],
   'related_origins' : [] | [Array<string>],
   'feature_flag_continue_from_another_device' : [] | [boolean],
   'openid_configs' : [] | [Array<OpenIdConfig>],

src/frontend/src/lib/state/featureFlags.ts

@@ -99,6 +99,7 @@ export const ADD_ACCESS_METHOD = createFeatureFlagStore(
 export const ENABLE_GENERIC_OPEN_ID = createFeatureFlagStore(
   "ENABLE_GENERIC_OPEN_ID",
   false,
+  () => canisterConfig.feature_flag_enable_generic_open_id_fe[0],
 );
 
 export const CONTINUE_FROM_ANOTHER_DEVICE = createFeatureFlagStore(

src/frontend/src/lib/utils/domainUtils.test.ts

@@ -22,6 +22,7 @@ describe("isOfficialOrigin", () => {
     new_flow_origins: [],
     dummy_auth: [],
     feature_flag_continue_from_another_device: [],
+    feature_flag_enable_generic_open_id_fe: [],
   });
 
   // Default related origins for most tests

src/frontend/src/lib/utils/iiConnection.test.ts

@@ -82,6 +82,7 @@ const DEFAULT_INIT: InternetIdentityInit = {
   new_flow_origins: [],
   dummy_auth: [],
   feature_flag_continue_from_another_device: [],
+  feature_flag_enable_generic_open_id_fe: [],
 };
 
 const mockActor = {

src/frontend/src/lib/utils/isRegistrationAllowed.test.ts

@@ -22,6 +22,7 @@ describe("isRegistrationAllowed", () => {
       new_flow_origins: [],
       dummy_auth: [],
       feature_flag_continue_from_another_device: [],
+      feature_flag_enable_generic_open_id_fe: [],
     };
   };
 

src/internet_identity/internet_identity.did

@@ -291,6 +291,7 @@ type InternetIdentityInit = record {
     dummy_auth : opt opt DummyAuthConfig;
     // Feature flags
     feature_flag_continue_from_another_device : opt bool;
+    feature_flag_enable_generic_open_id_fe : opt bool;
 };
 
 type ChallengeKey = text;

src/internet_identity/src/main.rs

@@ -503,6 +503,8 @@ fn config() -> InternetIdentityInit {
         dummy_auth: Some(persistent_state.dummy_auth.clone()),
         feature_flag_continue_from_another_device: persistent_state
             .feature_flag_continue_from_another_device,
+        feature_flag_enable_generic_open_id_fe: persistent_state
+            .feature_flag_enable_generic_open_id_fe,
     })
 }
 
@@ -634,6 +636,11 @@ fn apply_install_arg(maybe_arg: Option<InternetIdentityInit>) {
                 persistent_state.feature_flag_continue_from_another_device = Some(flag);
             })
         }
+        if let Some(flag) = arg.feature_flag_enable_generic_open_id_fe {
+            state::persistent_state_mut(|persistent_state| {
+                persistent_state.feature_flag_enable_generic_open_id_fe = Some(flag);
+            })
+        }
     }
 }
 

src/internet_identity/src/state.rs

@@ -144,6 +144,7 @@ pub struct PersistentState {
     pub dummy_auth: Option<DummyAuthConfig>,
     // Feature flags
     pub feature_flag_continue_from_another_device: Option<bool>,
+    pub feature_flag_enable_generic_open_id_fe: Option<bool>,
 }
 
 impl Default for PersistentState {
@@ -168,6 +169,7 @@ impl Default for PersistentState {
             is_production: None,
             dummy_auth: None,
             feature_flag_continue_from_another_device: None,
+            feature_flag_enable_generic_open_id_fe: None,
         }
     }
 }

src/internet_identity/src/storage/storable/storable_persistent_state.rs

@@ -45,6 +45,7 @@ pub struct StorablePersistentState {
 
     // Feature flags
     feature_flag_continue_from_another_device: Option<bool>,
+    feature_flag_enable_generic_open_id_fe: Option<bool>,
 }
 
 impl Storable for StorablePersistentState {
@@ -92,6 +93,7 @@ impl From<PersistentState> for StorablePersistentState {
             is_production: s.is_production,
             dummy_auth: s.dummy_auth,
             feature_flag_continue_from_another_device: s.feature_flag_continue_from_another_device,
+            feature_flag_enable_generic_open_id_fe: s.feature_flag_enable_generic_open_id_fe,
         }
     }
 }
@@ -117,6 +119,7 @@ impl From<StorablePersistentState> for PersistentState {
             is_production: s.is_production,
             dummy_auth: s.dummy_auth,
             feature_flag_continue_from_another_device: s.feature_flag_continue_from_another_device,
+            feature_flag_enable_generic_open_id_fe: s.feature_flag_enable_generic_open_id_fe,
         }
     }
 }
@@ -170,6 +173,7 @@ mod tests {
             is_production: None,
             dummy_auth: None,
             feature_flag_continue_from_another_device: None,
+            feature_flag_enable_generic_open_id_fe: None,
         };
 
         assert_eq!(StorablePersistentState::default(), expected_defaults);
@@ -199,6 +203,7 @@ mod tests {
             is_production: None,
             dummy_auth: None,
             feature_flag_continue_from_another_device: None,
+            feature_flag_enable_generic_open_id_fe: None,
         };
         assert_eq!(PersistentState::default(), expected_defaults);
     }