Fix link to github CI job run id (#2969)

* Fix link to github CI job run id

* Add test and fix two extra quotes

* Revert test

Author: Llorenç Muntaner

.github/workflows/canister-tests.yml

@@ -907,7 +907,7 @@ jobs:
         if: ${{ startsWith(github.ref, 'refs/tags/') && failure() }}
         with:
           WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-          MESSAGE: "Release creation failed: https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID"
+          MESSAGE: "Release creation failed: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
 
   # A native, fast cached build. We use the produced test assets to run the canister & e2e tests.
   # The asset's checksum is compared against that of the (slower) docker build.

.github/workflows/deploy-rc.yml

@@ -87,7 +87,7 @@ jobs:
             RC link: https://${{ env.ii_canister_id }}.ic0.app
             test app: https://${{ env.testnet_app_canister_id }}.ic0.app
 
-            https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID
+            https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}
 
         # Since the this is a scheduled job, a failure won't be shown on any
         # PR status. To notify the team, we send a message to our Slack channel on failure.
@@ -96,4 +96,4 @@ jobs:
         if: ${{ failure() }}
         with:
           WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-          MESSAGE: "RC deployment failed: https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID"
+          MESSAGE: "RC deployment failed: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"

.github/workflows/release-build-check.yml

@@ -49,7 +49,7 @@ jobs:
         if: ${{ failure() }}
         with:
           WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-          MESSAGE: "Release build check failed (could not get release): https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID"
+          MESSAGE: "Release build check failed (could not get release): https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
 
   # Perform the clean build (non-docker), using the release as checkout
   clean-build:
@@ -75,7 +75,7 @@ jobs:
         if: ${{ failure() }}
         with:
           WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-          MESSAGE: "Release build check failed: https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID"
+          MESSAGE: "Release build check failed: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
 
   # Verify the hash using the verify-hash script, using the release as checkout.
   # This runs the build using docker and should work on all platforms.
@@ -103,4 +103,4 @@ jobs:
         if: ${{ failure() }}
         with:
           WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-          MESSAGE: "Verify hash check failed: https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID"
+          MESSAGE: "Verify hash check failed: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"

.github/workflows/update-dapps.yml

@@ -48,4 +48,4 @@ jobs:
         if: ${{ failure() }}
         with:
           WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-          MESSAGE: "Dapps update failed: https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID"
+          MESSAGE: "Dapps update failed: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"

.github/workflows/update-dfx.yml

@@ -59,4 +59,4 @@ jobs:
         if: ${{ failure() }}
         with:
           WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-          MESSAGE: "dfx update failed: https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID"
+          MESSAGE: "dfx update failed: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"

.github/workflows/update-didc.yml

@@ -58,4 +58,4 @@ jobs:
         if: ${{ failure() }}
         with:
           WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-          MESSAGE: "didc update failed: https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID"
+          MESSAGE: "didc update failed: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"

.github/workflows/update-node.yml

@@ -60,4 +60,4 @@ jobs:
         if: ${{ failure() }}
         with:
           WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-          MESSAGE: "Node update failed: https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID"
+          MESSAGE: "Node update failed: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"

.github/workflows/update-passkey-aaguid.yml

@@ -57,4 +57,4 @@ jobs:
         if: ${{ failure() }}
         with:
           WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-          MESSAGE: "Passkey AAGUID data update failed: https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID"
+          MESSAGE: "Passkey AAGUID data update failed: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"

.github/workflows/update-rust.yml

@@ -67,4 +67,4 @@ jobs:
         if: ${{ failure() }}
         with:
           WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-          MESSAGE: "Rust update failed: https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID"
+          MESSAGE: "Rust update failed: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"