Skip to content

Commit f141f90

Browse files
authored
build!: replace forked solana-* crates by latest releases (#197)
(XC-297) This PR updates all `solana-*` crates to their latest v3 releases, which introduce breaking changes. * **Dependency cleanup:** The v3 `solana-*` crates no longer depend on `wasm-bindgen`. This eliminates the need for our custom forks of `solana-sdk` and `solana-system-program`. As a result, all `[patch.crates-io]` sections have been removed from `Cargo.toml` files. * **ICP Ninja deployment:** The ICP Ninja deployment of `basic_solana` uses the latest published version of `sol_rpc_client` on crates.io. That version still depends on the older v2 `solana-*` crates. To accommodate this, the ICP Ninja deployment is temporarily branched from the local and mainnet deployments, which now use the v3 crates. BREAKING CHANGES: This update is breaking for the `sol_rpc_types` and `sol_rpc_client` crates, as they re-export many types from the `solana-*` crates.
1 parent 6a90008 commit f141f90

File tree

21 files changed

+1482
-1166
lines changed

21 files changed

+1482
-1166
lines changed

.github/workflows/ci.yml

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -34,19 +34,20 @@ jobs:
3434
- name: 'Check Cargo.toml'
3535
run: cargo sort --workspace --check
3636

37-
check-ninja-cargo-toml:
38-
runs-on: ubuntu-latest
39-
steps:
40-
- name: 'Checkout'
41-
uses: actions/checkout@v4
42-
43-
- name: 'Set up Python'
44-
uses: actions/setup-python@v5
45-
with:
46-
python-version: '3.11'
47-
48-
- name: 'Check ninja Cargo.toml'
49-
run: python3 .github/scripts/check_ninja_cargo_toml.py
37+
# TODO XC-XXX: Re-enable once `sol_rpc_client` v3.0.0 is released and ICP Ninja deployment of `basic_solana` is reverted
38+
# check-ninja-cargo-toml:
39+
# runs-on: ubuntu-latest
40+
# steps:
41+
# - name: 'Checkout'
42+
# uses: actions/checkout@v4
43+
#
44+
# - name: 'Set up Python'
45+
# uses: actions/setup-python@v5
46+
# with:
47+
# python-version: '3.11'
48+
#
49+
# - name: 'Check ninja Cargo.toml'
50+
# run: python3 .github/scripts/check_ninja_cargo_toml.py
5051

5152
check-cargo-lock:
5253
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)