Commit 91cd429
fix(frontend): address Copilot review comments and remove stale dfx artifacts
- Remove dfx-generated index.js, index.d.ts, and raw .did files from both
declaration directories (ic_vetkeys_encrypted_maps_canister and
ic_vetkeys_manager_canister). These used @dfinity/agent and dfx-specific
env vars (DFX_NETWORK, CANISTER_ID_*) and are no longer needed now that
the library uses @icp-sdk/core.
- Fix encrypted_maps_canister.ts: split idlFactory (value import) from
_SERVICE/AccessRights/ByteBuf/EncryptedMapData (type-only imports via
import type). The .did.js module only exports idlFactory and init at
runtime; importing types as values would fail under strict ESM.
- Fix key_manager/index.ts: change import source from the raw Candid text
file (.did) to the generated JS module (.did.js), and use import type
for type-only symbols.
- Fix make_did_bindings.sh: add explicit / path separator between DIR and
NAME so the function is robust if DIR is passed without a trailing slash.
- Fix provision-frontend-linux.sh: remove sudo from rustup install; sudo
installs into root's home while subsequent steps add $HOME/.cargo/bin
(runner's home) to PATH, causing cargo to not be found.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 343eb43 commit 91cd429
File tree
10 files changed
+7
-251
lines changed- .github/workflows
- frontend/ic_vetkeys
- src
- declarations
- ic_vetkeys_encrypted_maps_canister
- ic_vetkeys_manager_canister
- encrypted_maps
- key_manager
10 files changed
+7
-251
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
Lines changed: 0 additions & 41 deletions
This file was deleted.
Lines changed: 0 additions & 50 deletions
This file was deleted.
Lines changed: 0 additions & 42 deletions
This file was deleted.
Lines changed: 0 additions & 19 deletions
This file was deleted.
Lines changed: 0 additions & 50 deletions
This file was deleted.
Lines changed: 0 additions & 42 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
0 commit comments