Skip to content

Commit 9d51aa9

Browse files
authored
chore: in examples fix incorrect handling of some key ids and mainnet frontend configuration (#133)
- Fixed Problem 1: In some cases `agentOptions` were not passed down to the actor creation function if deploying the frontend to mainnet. - Fixed Problem 2: In some cases the key name that was set on canister initialization was ignored and instead `"dfx_test_key"` was always used.
1 parent 26f7732 commit 9d51aa9

4 files changed

Lines changed: 20 additions & 27 deletions

File tree

examples/basic_ibe/backend/src/lib.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ async fn get_root_ibe_public_key() -> VetKeyPublicKey {
7272
let request = VetKDPublicKeyRequest {
7373
canister_id: None,
7474
context: DOMAIN_SEPARATOR.as_bytes().to_vec(),
75-
key_id: bls12_381_dfx_test_key(),
75+
key_id: key_id(),
7676
};
7777

7878
let (result,) = ic_cdk::api::call::call::<_, (VetKDPublicKeyReply,)>(
@@ -93,7 +93,7 @@ async fn get_my_encrypted_ibe_key(transport_key: TransportPublicKey) -> Encrypte
9393
let request = VetKDDeriveKeyRequest {
9494
input: caller.as_ref().to_vec(),
9595
context: DOMAIN_SEPARATOR.as_bytes().to_vec(),
96-
key_id: bls12_381_dfx_test_key(),
96+
key_id: key_id(),
9797
transport_public_key: transport_key.into_vec(),
9898
};
9999

@@ -130,10 +130,10 @@ fn remove_my_message_by_index(message_index: usize) -> Result<(), String> {
130130
})
131131
}
132132

133-
fn bls12_381_dfx_test_key() -> VetKDKeyId {
133+
fn key_id() -> VetKDKeyId {
134134
VetKDKeyId {
135135
curve: VetKDCurve::Bls12_381_G2,
136-
name: "dfx_test_key".to_string(),
136+
name: KEY_NAME.with_borrow(|key_name| key_name.get().clone()),
137137
}
138138
}
139139

examples/basic_ibe/frontend/src/main.ts

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,12 @@ function getBasicIbeCanister(): ActorSubclass<_SERVICE> {
3737
? `https://${process.env.CANISTER_ID_BASIC_IBE}.ic0.app`
3838
: "http://localhost:8000";
3939

40-
basicIbeCanister = createActor(
41-
process.env.CANISTER_ID_BASIC_IBE,
42-
process.env.DFX_NETWORK === "ic"
43-
? undefined
44-
: {
45-
agentOptions: {
46-
identity: authClient.getIdentity(),
47-
host,
48-
},
49-
},
50-
);
40+
basicIbeCanister = createActor(process.env.CANISTER_ID_BASIC_IBE, {
41+
agentOptions: {
42+
identity: authClient.getIdentity(),
43+
host,
44+
},
45+
});
5146

5247
return basicIbeCanister;
5348
}

examples/basic_timelock_ibe/backend/src/lib.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ async fn get_root_ibe_public_key() -> VetKeyPublicKey {
107107
let request = VetKDPublicKeyRequest {
108108
canister_id: None,
109109
context: DOMAIN_SEPARATOR.as_bytes().to_vec(),
110-
key_id: bls12_381_dfx_test_key(),
110+
key_id: key_id(),
111111
};
112112

113113
let (result,) = ic_cdk::api::call::call::<_, (VetKDPublicKeyReply,)>(
@@ -306,7 +306,7 @@ async fn decrypt_bids(
306306
let request = VetKDDeriveKeyRequest {
307307
context: DOMAIN_SEPARATOR.as_bytes().to_vec(),
308308
input: lot_id.to_le_bytes().to_vec(),
309-
key_id: bls12_381_dfx_test_key(),
309+
key_id: key_id(),
310310
transport_public_key: transport_secret_key.public_key().to_vec(),
311311
};
312312

@@ -374,10 +374,10 @@ fn is_authenticated() -> Result<(), String> {
374374
}
375375
}
376376

377-
fn bls12_381_dfx_test_key() -> VetKDKeyId {
377+
fn key_id() -> VetKDKeyId {
378378
VetKDKeyId {
379379
curve: VetKDCurve::Bls12_381_G2,
380-
name: "dfx_test_key".to_string(),
380+
name: KEY_NAME.with_borrow(|key_name| key_name.get().clone()),
381381
}
382382
}
383383

examples/basic_timelock_ibe/frontend/src/main.ts

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,14 +39,12 @@ function getBasicTimelockIbeCanister(): ActorSubclass<_SERVICE> {
3939

4040
basicTimelockIbeCanister = createActor(
4141
process.env.CANISTER_ID_BASIC_TIMELOCK_IBE,
42-
process.env.DFX_NETWORK === "ic"
43-
? undefined
44-
: {
45-
agentOptions: {
46-
identity: authClient.getIdentity(),
47-
host,
48-
},
49-
},
42+
{
43+
agentOptions: {
44+
identity: authClient.getIdentity(),
45+
host,
46+
},
47+
},
5048
);
5149

5250
return basicTimelockIbeCanister;

0 commit comments

Comments
 (0)