Skip to content

Commit f32b3d5

Browse files
committed
Removes @aspect_rules_rollup dependency.
Refs #56. In #26 we updated the Rollup integration to use a custom rule which directly invokes the `rollup` binary, so there's no need for `@aspect_rules_rollup` anymore.
1 parent 85d3cf7 commit f32b3d5

4 files changed

Lines changed: 0 additions & 30 deletions

File tree

WORKSPACE.bazel

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -77,20 +77,6 @@ jasmine_repositories(name = "jasmine")
7777
load("@jasmine//:npm_repositories.bzl", jasmine_npm_repositories = "npm_repositories")
7878
jasmine_npm_repositories()
7979

80-
# Install `@aspect_rules_rollup`.
81-
http_archive(
82-
name = "aspect_rules_rollup",
83-
sha256 = "2a0c863fa4ca35cc2d49b63637792d38262f71fc0590c76b7946838614c94fda",
84-
strip_prefix = "rules_rollup-0.13.0",
85-
url = "https://github.com/aspect-build/rules_rollup/archive/refs/tags/v0.13.0.tar.gz",
86-
)
87-
load("@aspect_rules_rollup//rollup:dependencies.bzl", "rules_rollup_dependencies")
88-
rules_rollup_dependencies()
89-
load("@aspect_rules_rollup//rollup:repositories.bzl", "rollup_repositories")
90-
rollup_repositories(name = "rollup")
91-
load("@rollup//:npm_repositories.bzl", rollup_npm_repositories = "npm_repositories")
92-
rollup_npm_repositories()
93-
9480
# Load bazel_skylib.
9581
http_archive(
9682
name = "bazel_skylib",

dependencies.bzl

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,6 @@ def rules_prerender_dependencies():
1313
url = "https://github.com/aspect-build/rules_js/releases/download/v1.19.0/rules_js-v1.19.0.tar.gz",
1414
)
1515

16-
maybe(
17-
http_archive,
18-
name = "aspect_rules_rollup",
19-
sha256 = "2a0c863fa4ca35cc2d49b63637792d38262f71fc0590c76b7946838614c94fda",
20-
strip_prefix = "rules_rollup-0.13.0",
21-
url = "https://github.com/aspect-build/rules_rollup/archive/refs/tags/v0.13.0.tar.gz",
22-
)
23-
2416
maybe(
2517
http_archive,
2618
name = "aspect_rules_ts",

npm_repositories.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
load("@jasmine//:npm_repositories.bzl", jasmine_npm_repositories = "npm_repositories")
2-
load("@rollup//:npm_repositories.bzl", rollup_npm_repositories = "npm_repositories")
32
load("@rules_prerender_npm//:repositories.bzl", js_npm_repositories = "npm_repositories")
43

54
def npm_repositories():
65
js_npm_repositories()
7-
rollup_npm_repositories()
86
jasmine_npm_repositories()

repositories.bzl

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
load("@aspect_rules_jasmine//jasmine:repositories.bzl", "jasmine_repositories")
22
load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")
33
load("@aspect_rules_js//npm:npm_import.bzl", "npm_translate_lock")
4-
load("@aspect_rules_rollup//rollup:dependencies.bzl", "rules_rollup_dependencies")
5-
load("@aspect_rules_rollup//rollup:repositories.bzl", "rollup_repositories")
64
load("@aspect_rules_ts//ts:repositories.bzl", "rules_ts_dependencies")
75

86
def rules_prerender_repositories():
@@ -15,9 +13,5 @@ def rules_prerender_repositories():
1513

1614
rules_ts_dependencies(ts_version_from = Label("//:package.json"))
1715

18-
if "rollup" not in native.existing_rules():
19-
rules_rollup_dependencies()
20-
rollup_repositories(name = "rollup")
21-
2216
if "jasmine" not in native.existing_rules():
2317
jasmine_repositories(name = "jasmine")

0 commit comments

Comments
 (0)