Skip to content

Commit 33a196d

Browse files
author
Shiva
committed
resolve review comments
1 parent d9c805e commit 33a196d

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

dgraph/cmd/dgraphimport/import_test.go

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ const expectedSchema = `{
6363
}`
6464

6565
func TestDrainModeAfterStartSnapshotStream(t *testing.T) {
66-
// t.Skip("Skipping... sometimes the query for schema succeeds even when the server is in draining mode")
67-
6866
tests := []struct {
6967
name string
7068
numAlphas int
@@ -111,8 +109,6 @@ func TestDrainModeAfterStartSnapshotStream(t *testing.T) {
111109
}
112110

113111
func TestImportApis(t *testing.T) {
114-
// t.Skip("Skipping import tests due to persistent flakiness with container networking and Raft leadership issues")
115-
116112
tests := []testcase{
117113
{
118114
name: "SingleGroupShutTwoAlphasPerGroup",
@@ -379,12 +375,12 @@ func verifyImportResults(t *testing.T, gc *dgraphapi.GrpcClient, downAlphas int)
379375
}
380376

381377
retryDelay := time.Second
382-
hasAllPredicates := true
383378

384379
// Get expected predicates first
385380
var expectedSchemaObj map[string]interface{}
386381
require.NoError(t, json.Unmarshal([]byte(expectedSchema), &expectedSchemaObj))
387382
expectedPredicates := getPredicateMap(expectedSchemaObj)
383+
var hasAllPredicates bool
388384

389385
for i := 0; i < maxRetries; i++ {
390386
// Checking client connection again here because an import operation may be in progress on the rejoined alpha
@@ -400,8 +396,7 @@ func verifyImportResults(t *testing.T, gc *dgraphapi.GrpcClient, downAlphas int)
400396
// Get actual predicates
401397
actualPredicates := getPredicateMap(actualSchema)
402398

403-
hasAllPredicates := true
404-
// Check if all expected predicates are present
399+
hasAllPredicates = true
405400
for predName := range expectedPredicates {
406401
if _, exists := actualPredicates[predName]; !exists {
407402
hasAllPredicates = false

0 commit comments

Comments
 (0)