Skip to content

Commit 6337680

Browse files
ShivaShiva
authored andcommitted
resolve review comments
1 parent d425167 commit 6337680

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

dgraph/cmd/dgraphimport/import_test.go

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ func TestEmptyBulkOutDir(t *testing.T) {
7575
}
7676

7777
func TestDrainModeAfterStartSnapshotStream(t *testing.T) {
78-
// t.Skip("Skipping... sometimes the query for schema succeeds even when the server is in draining mode")
79-
8078
tests := []struct {
8179
name string
8280
numAlphas int
@@ -123,8 +121,6 @@ func TestDrainModeAfterStartSnapshotStream(t *testing.T) {
123121
}
124122

125123
func TestImportApis(t *testing.T) {
126-
// t.Skip("Skipping import tests due to persistent flakiness with container networking and Raft leadership issues")
127-
128124
tests := []testcase{
129125
{
130126
name: "SingleGroupShutTwoAlphasPerGroup",
@@ -391,12 +387,12 @@ func verifyImportResults(t *testing.T, gc *dgraphapi.GrpcClient, downAlphas int)
391387
}
392388

393389
retryDelay := time.Second
394-
hasAllPredicates := true
395390

396391
// Get expected predicates first
397392
var expectedSchemaObj map[string]interface{}
398393
require.NoError(t, json.Unmarshal([]byte(expectedSchema), &expectedSchemaObj))
399394
expectedPredicates := getPredicateMap(expectedSchemaObj)
395+
var hasAllPredicates bool
400396

401397
for i := 0; i < maxRetries; i++ {
402398
// Checking client connection again here because an import operation may be in progress on the rejoined alpha
@@ -412,8 +408,7 @@ func verifyImportResults(t *testing.T, gc *dgraphapi.GrpcClient, downAlphas int)
412408
// Get actual predicates
413409
actualPredicates := getPredicateMap(actualSchema)
414410

415-
hasAllPredicates := true
416-
// Check if all expected predicates are present
411+
hasAllPredicates = true
417412
for predName := range expectedPredicates {
418413
if _, exists := actualPredicates[predName]; !exists {
419414
hasAllPredicates = false

0 commit comments

Comments
 (0)