HTML Color email notifications changed to now display diff by word

[8rror404]

Describe the bug
Since v0.52.1 when the - Faster server-side "difference" rendering on History page (#3442) was introduced, email notifications using HTML Color now display changes by Words rather than Lines.

Whilst the difference page allows either option:

The email notification output has changed to Words rather than Lines. This makes the email output significantly harder to read, losing all clarity. Screenshot below:

On the left is the diff page (dark mode), on the right the email notification. The change from Published 1 day ago to Published 2 Days ago highlights the problem of clarity within the email:

Version
0.52.4

How did you install?

Docker

To Reproduce

Steps to reproduce the behavior:
Compare the output of an HTML Color email notification with the diff page (set as default - Lines).

Expected behavior
The HTML Color Notification should behave as previous versions and display diffs by lines. This would match the default view of the diff screen. An option could be added to display diffs by word in notifications if required.

Screenshots
Included above

Desktop (please complete the following information):

• OS: Windows 11
• Browser: Firefox
• email: Outlook

[dgtlmoon]

email notifications using HTML Color now display changes by Words rather than Lines.

so you're saying whats sent in the actual email is word-by-word difference right, rather than line-by-line compare?

[dgtlmoon]

The HTML Color Notification should behave as previous versions and display diffs by lines. This would match the default view of the diff screen. An option could be added to display diffs by word in notifications if required.

agreed, hmm must be some setting thats not being common between the two, i'll check that

[8rror404]

agreed, hmm must be some setting thats not being common between the two, i'll check that

Many thanks. I have done some further testing:

1. recheck a watch and get a diff
2. On the diff screen toggle between Words and Lines

If there is no change in the way that the difference is displayed on the diff screen, the HTML Color notification email displays correctly.

If there is a change in the way that the difference is displayed on the diff screen, the HTML Color notification email displays the Words output.

Therefore when testing this it is important that the change registers a Words level diff.

I hope this makes sense and helps...

[dgtlmoon]

@8rror404 I'm unable to reproduce this hmm, i added really

<span style="background-color: #eaf2c2; color: #406619;" role="note" aria-label="Changed into" title="Changed into">So let's see reallywhat happens.</span>

[8rror404]

Hi I have just checked this further.

If the change is detected as a new line, all is ok.
If the change is detected as a changed line, the notification displays at Words level.

I hope this helps.

[dgtlmoon]

Ahhh, ok thanks a lot

[dgtlmoon]

changedetection.io/changedetectionio/notification/handler.py

Line 360 in 240340e

word_diff=False if requested_output_format_original == 'text' else True,

hmm