style(lint): apply biome lint autofixes and fix iterable-callback returns

Mechanical cleanup surfaced by enabling Biome lint: node: import protocol,
`import type`, removal of unused imports/vars/members, template literals,
literal member access, optional chaining, Number.isNaN. Rewrites 9 forEach
callbacks that implicitly returned a value as for-of loops, and suppresses one
deliberate control-char regex (the ANSI stripper). No behavior change — 722
tests pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Piqz8qJ21eRpPrmWwxr6fg

Author: dhanesh

cli/__tests__/config.test.ts

@@ -6,8 +6,8 @@
  */
 
 import { describe, test, expect, beforeEach, afterEach } from 'bun:test';
-import { existsSync, mkdirSync, writeFileSync, rmSync } from 'fs';
-import { join } from 'path';
+import { existsSync, mkdirSync, writeFileSync, rmSync } from 'node:fs';
+import { join } from 'node:path';
 import {
   loadConfig,
   getTierPatterns,

cli/__tests__/drift.test.ts

@@ -6,8 +6,8 @@
  */
 
 import { describe, test, expect, beforeEach, afterEach } from 'bun:test';
-import { existsSync, mkdirSync, writeFileSync, rmSync, readFileSync } from 'fs';
-import { join } from 'path';
+import { existsSync, mkdirSync, writeFileSync, rmSync, readFileSync } from 'node:fs';
+import { join } from 'node:path';
 import { computeFileHash, detectDrift } from '../lib/evidence.js';
 
 // ============================================================

cli/__tests__/evidence.test.ts

@@ -7,16 +7,14 @@
  */
 
 import { describe, test, expect, beforeEach, afterEach } from 'bun:test';
-import { existsSync, mkdirSync, writeFileSync, rmSync } from 'fs';
-import { join } from 'path';
+import { existsSync, mkdirSync, writeFileSync, rmSync } from 'node:fs';
+import { join } from 'node:path';
 import {
   computeFileHash,
   detectDrift,
   parseTestAnnotations,
   buildTraceabilityMatrix,
   aggregateSatisfactionLevel,
-  type DriftReport,
-  type TraceabilityMatrix,
 } from '../lib/evidence.js';
 import type { Evidence } from '../lib/parser.js';
 
@@ -321,11 +319,11 @@ test('idempotent retry', () => {});
 
     const matrix = buildTraceabilityMatrix(['traced.test.ts'], TEST_DIR);
 
-    expect(matrix['B1']).toHaveLength(2);
-    expect(matrix['B1'][0].test_function).toBe('no duplicates');
-    expect(matrix['B1'][1].test_function).toBe('idempotent retry');
-    expect(matrix['T1']).toHaveLength(1);
-    expect(matrix['T1'][0].test_function).toBe('idempotent retry');
+    expect(matrix.B1).toHaveLength(2);
+    expect(matrix.B1[0].test_function).toBe('no duplicates');
+    expect(matrix.B1[1].test_function).toBe('idempotent retry');
+    expect(matrix.T1).toHaveLength(1);
+    expect(matrix.T1[0].test_function).toBe('idempotent retry');
   });
 
   test('handles multiple test files', () => {
@@ -345,9 +343,9 @@ test('test B', () => {});
     );
 
     const matrix = buildTraceabilityMatrix(['a.test.ts', 'b.test.ts'], TEST_DIR);
-    expect(matrix['B1']).toHaveLength(2);
-    expect(matrix['B1'].map((e) => e.test_file)).toContain('a.test.ts');
-    expect(matrix['B1'].map((e) => e.test_file)).toContain('b.test.ts');
+    expect(matrix.B1).toHaveLength(2);
+    expect(matrix.B1.map((e) => e.test_file)).toContain('a.test.ts');
+    expect(matrix.B1.map((e) => e.test_file)).toContain('b.test.ts');
   });
 
   test('returns empty matrix for files with no annotations', () => {

cli/__tests__/json-md-integration.test.ts

@@ -7,18 +7,11 @@
  */
 
 import { describe, test, expect, beforeEach, afterEach } from 'bun:test';
-import { mkdirSync, writeFileSync, rmSync, existsSync } from 'fs';
-import { join } from 'path';
+import { mkdirSync, writeFileSync, rmSync, existsSync } from 'node:fs';
+import { join } from 'node:path';
 
 // Parser functions (status, graph, verify, solve)
-import {
-  loadFeature,
-  getFeatureFiles,
-  findManifoldDir,
-  listFeatures,
-  type FeatureData,
-  type FeatureFiles,
-} from '../lib/parser.js';
+import { loadFeature, getFeatureFiles, findManifoldDir, listFeatures } from '../lib/parser.js';
 
 // Linker functions (validate, show)
 import {
@@ -207,7 +200,7 @@ This constraint exists in both JSON and Markdown.
 function createTestDir(): string {
   const dir = join(
     '/tmp',
-    'manifold-jsonmd-test-' + Date.now() + '-' + Math.random().toString(36).slice(2)
+    `manifold-jsonmd-test-${Date.now()}-${Math.random().toString(36).slice(2)}`
   );
   mkdirSync(dir, { recursive: true });
   return dir;
@@ -838,7 +831,7 @@ describe('Feature Listing', () => {
   });
 
   test('returns empty array for nonexistent directory', () => {
-    const features = listFeatures('/tmp/manifold-does-not-exist-' + Date.now());
+    const features = listFeatures(`/tmp/manifold-does-not-exist-${Date.now()}`);
     expect(features).toEqual([]);
   });
 

cli/__tests__/manifold-linker.test.ts

@@ -4,8 +4,8 @@
  */
 
 import { describe, test, expect, beforeEach, afterEach } from 'bun:test';
-import { mkdirSync, writeFileSync, rmSync, existsSync } from 'fs';
-import { join } from 'path';
+import { mkdirSync, writeFileSync, rmSync, existsSync } from 'node:fs';
+import { join } from 'node:path';
 import {
   validateManifoldLink,
   loadAndValidateManifold,
@@ -261,7 +261,7 @@ Description.
 });
 
 describe('detectManifoldFormat', () => {
-  const testDir = '/tmp/manifold-test-' + Date.now();
+  const testDir = `/tmp/manifold-test-${Date.now()}`;
 
   beforeEach(() => {
     mkdirSync(testDir, { recursive: true });
@@ -303,7 +303,7 @@ describe('detectManifoldFormat', () => {
 });
 
 describe('loadAndValidateManifold', () => {
-  const testDir = '/tmp/manifold-load-test-' + Date.now();
+  const testDir = `/tmp/manifold-load-test-${Date.now()}`;
 
   beforeEach(() => {
     mkdirSync(testDir, { recursive: true });
@@ -400,7 +400,7 @@ This is the statement.
 });
 
 describe('loadManifoldByFeature', () => {
-  const testDir = '/tmp/manifold-feature-test-' + Date.now();
+  const testDir = `/tmp/manifold-feature-test-${Date.now()}`;
 
   beforeEach(() => {
     mkdirSync(testDir, { recursive: true });

cli/__tests__/structure-schema.test.ts

@@ -14,8 +14,6 @@ import {
   PhaseSchema,
   ConstraintTypeSchema,
   TensionTypeSchema,
-  TensionStatusSchema,
-  RequiredTruthStatusSchema,
 } from '../lib/structure-schema.js';
 
 describe('PhaseSchema', () => {

cli/__tests__/verify-flags.test.ts

@@ -6,8 +6,8 @@
  */
 
 import { describe, test, expect, beforeEach, afterEach } from 'bun:test';
-import { existsSync, mkdirSync, writeFileSync, rmSync } from 'fs';
-import { join } from 'path';
+import { existsSync, mkdirSync, writeFileSync, rmSync } from 'node:fs';
+import { join } from 'node:path';
 import {
   aggregateSatisfactionLevel,
   verifyAllEvidence,
@@ -90,10 +90,10 @@ describe('--levels flag: satisfaction level computation', () => {
       levels[id] = aggregateSatisfactionLevel(evidence);
     }
 
-    expect(levels['B1']).toBe('VERIFIED');
-    expect(levels['B2']).toBe('IMPLEMENTED');
-    expect(levels['T1']).toBe('DOCUMENTED');
-    expect(levels['S1']).toBe('DOCUMENTED');
+    expect(levels.B1).toBe('VERIFIED');
+    expect(levels.B2).toBe('IMPLEMENTED');
+    expect(levels.T1).toBe('DOCUMENTED');
+    expect(levels.S1).toBe('DOCUMENTED');
   });
 
   test('level counts for bar chart display', () => {
@@ -115,10 +115,10 @@ describe('--levels flag: satisfaction level computation', () => {
       counts[level] = (counts[level] || 0) + 1;
     }
 
-    expect(counts['DOCUMENTED']).toBe(1);
-    expect(counts['IMPLEMENTED']).toBe(1);
-    expect(counts['TESTED']).toBe(2);
-    expect(counts['VERIFIED']).toBe(1);
+    expect(counts.DOCUMENTED).toBe(1);
+    expect(counts.IMPLEMENTED).toBe(1);
+    expect(counts.TESTED).toBe(2);
+    expect(counts.VERIFIED).toBe(1);
   });
 });
 

cli/__tests__/workflow.test.ts

@@ -477,27 +477,27 @@ describe('phase transition rules', () => {
   };
 
   test('INITIALIZED can only transition to CONSTRAINED', () => {
-    expect(validTransitions['INITIALIZED']).toEqual(['CONSTRAINED']);
+    expect(validTransitions.INITIALIZED).toEqual(['CONSTRAINED']);
   });
 
   test('CONSTRAINED can only transition to TENSIONED', () => {
-    expect(validTransitions['CONSTRAINED']).toEqual(['TENSIONED']);
+    expect(validTransitions.CONSTRAINED).toEqual(['TENSIONED']);
   });
 
   test('TENSIONED can only transition to ANCHORED', () => {
-    expect(validTransitions['TENSIONED']).toEqual(['ANCHORED']);
+    expect(validTransitions.TENSIONED).toEqual(['ANCHORED']);
   });
 
   test('ANCHORED can only transition to GENERATED', () => {
-    expect(validTransitions['ANCHORED']).toEqual(['GENERATED']);
+    expect(validTransitions.ANCHORED).toEqual(['GENERATED']);
   });
 
   test('GENERATED can only transition to VERIFIED', () => {
-    expect(validTransitions['GENERATED']).toEqual(['VERIFIED']);
+    expect(validTransitions.GENERATED).toEqual(['VERIFIED']);
   });
 
   test('VERIFIED can transition back to INITIALIZED for iteration', () => {
-    expect(validTransitions['VERIFIED']).toContain('INITIALIZED');
+    expect(validTransitions.VERIFIED).toContain('INITIALIZED');
   });
 });
 

cli/commands/completion.ts

@@ -5,7 +5,7 @@
  * Satisfies: U4 (Shell completion support for feature names)
  */
 
-import { Command } from 'commander';
+import type { Command } from 'commander';
 import { findManifoldDir, listFeatures } from '../lib/parser.js';
 
 // Bash completion script template
@@ -329,7 +329,7 @@ export function registerCompletionCommand(program: Command): void {
       const manifoldDir = findManifoldDir();
       if (manifoldDir) {
         const features = listFeatures(manifoldDir);
-        features.forEach((f) => console.log(f));
+        for (const f of features) console.log(f);
       }
     });
 }

cli/commands/doctor.ts

@@ -6,7 +6,7 @@
  */
 
 import type { Command } from 'commander';
-import { dirname } from 'path';
+import { dirname } from 'node:path';
 import { findManifoldDir } from '../lib/parser.js';
 import { runDoctor, type DoctorReport } from '../lib/doctor.js';
 import { println, printError, formatHeader, formatKeyValue, style, toJSON } from '../lib/output.js';
@@ -26,7 +26,7 @@ export function registerDoctorCommand(program: Command): void {
       'Check repo health: detect invalid manifolds, constraint dependency cycles, plugin-sync drift, stale fingerprints, and file-drift'
     )
     .option('--json', 'Output as JSON')
-    .action(async function (this: Command, options: DoctorOptions) {
+    .action(async function (this: Command, _options: DoctorOptions) {
       // Use optsWithGlobals() to capture --json even when defined at parent level
       // Satisfies: RT-6 (U3) — --json must work whether passed as local or global flag
       const mergedOpts = this.optsWithGlobals() as DoctorOptions;