fix: synchronize secureCoalitionRadios access with atomic bool

Agent-Logs-Url: https://github.com/dharmab/skyeye/sessions/886ec486-f24f-4161-ac72-b67a3640af26

Co-authored-by: dharmab <4450708+dharmab@users.noreply.github.com>

Author: Copilot

pkg/simpleradio/client.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"net"
 	"sync"
+	"sync/atomic"
 	"time"
 
 	"github.com/dharmab/skyeye/pkg/simpleradio/types"
@@ -49,7 +50,7 @@ type Client struct {
 	clientsLock sync.RWMutex
 
 	// secureCoalitionRadios indicates if the client should only receive transmissions from the same coalition.
-	secureCoalitionRadios bool
+	secureCoalitionRadios atomic.Bool
 
 	// rxChan is a channel where received transmission are published. A read-only version is available publicly.
 	rxChan chan Transmission

pkg/simpleradio/message.go

@@ -78,13 +78,13 @@ func (c *Client) updateServerSettings(message types.Message) {
 	log.Debug().Any("serverSettings", message.ServerSettings).Msg("received server settings")
 	if enabled, ok := message.ServerSettings[string(types.CoalitionAudioSecurity)]; ok {
 		if strings.ToLower(enabled) == "true" {
-			if !c.secureCoalitionRadios {
+			if !c.secureCoalitionRadios.Load() {
 				log.Info().Msg("enabling secure coalition radios")
 			}
-			c.secureCoalitionRadios = true
+			c.secureCoalitionRadios.Store(true)
 		} else {
 			log.Info().Msg("disabling secure coalition radios")
-			c.secureCoalitionRadios = false
+			c.secureCoalitionRadios.Store(false)
 		}
 	}
 	if enabled, ok := message.ServerSettings[string(types.ExternalAWACSMode)]; ok {

pkg/simpleradio/message_test.go

@@ -0,0 +1,39 @@
+package simpleradio
+
+import (
+	"testing"
+
+	"github.com/dharmab/skyeye/pkg/simpleradio/types"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestUpdateServerSettingsSecureCoalitionRadios(t *testing.T) {
+	t.Parallel()
+
+	t.Run("enabled", func(t *testing.T) {
+		t.Parallel()
+		client := &Client{}
+
+		client.updateServerSettings(types.Message{
+			ServerSettings: map[string]string{
+				string(types.CoalitionAudioSecurity): "TrUe",
+			},
+		})
+
+		assert.True(t, client.secureCoalitionRadios.Load())
+	})
+
+	t.Run("disabled", func(t *testing.T) {
+		t.Parallel()
+		client := &Client{}
+		client.secureCoalitionRadios.Store(true)
+
+		client.updateServerSettings(types.Message{
+			ServerSettings: map[string]string{
+				string(types.CoalitionAudioSecurity): "false",
+			},
+		})
+
+		assert.False(t, client.secureCoalitionRadios.Load())
+	})
+}

pkg/simpleradio/receive.go

@@ -104,7 +104,7 @@ func (c *Client) receiveVoice(ctx context.Context, in <-chan []byte, out chan<-
 
 			logger := log.With().Str("GUID", string(packet.OriginGUID)).Logger()
 
-			if c.secureCoalitionRadios {
+			if c.secureCoalitionRadios.Load() {
 				client, ok := c.clients[types.GUID(packet.OriginGUID)]
 				if !ok {
 					logger.Warn().Msg("ignoring voice packet from unknown client")