Skip to content

Commit 4a1a60c

Browse files
committed
Adapt integration tests
1 parent 00b9061 commit 4a1a60c

File tree

3 files changed

+23
-24
lines changed

3 files changed

+23
-24
lines changed

e2e/src/test/java/org.dhatim.fastexcel.benchmarks/WriterBenchmark.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,16 @@ public Object poiStreaming() throws Exception {
5151
@Benchmark
5252
public Object fastExcel() throws IOException {
5353
CountingOutputStream count = new CountingOutputStream(new NullOutputStream());
54-
Workbook wb = new Workbook(count, "Perf", "1.0");
55-
Worksheet ws = wb.newWorksheet("Sheet 1");
56-
for (int r = 0; r < NB_ROWS; ++r) {
57-
ws.value(r, 0, r);
58-
ws.value(r, 1, Integer.toString(r % 1000));
59-
ws.value(r, 2, r / 87.0);
60-
ws.value(r, 3, new Date(1549915044));
54+
try(Workbook wb = new Workbook(count, "Perf", "1.0")){
55+
Worksheet ws = wb.newWorksheet("Sheet 1");
56+
for (int r = 0; r < NB_ROWS; ++r) {
57+
ws.value(r, 0, r);
58+
ws.value(r, 1, Integer.toString(r % 1000));
59+
ws.value(r, 2, r / 87.0);
60+
ws.value(r, 3, new Date(1549915044));
61+
}
62+
ws.range(0, 3, NB_ROWS - 1, 3).style().format("yyyy-mm-dd hh:mm:ss").set();
6163
}
62-
ws.range(0, 3, NB_ROWS - 1, 3).style().format("yyyy-mm-dd hh:mm:ss").set();
63-
wb.finish();
6464
return count.getCount();
6565
}
6666

e2e/src/test/java/org/dhatim/fastexcel/EncryptionTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,11 @@ public class EncryptionTest {
3030

3131

3232
void fastexcelWriteProtectTest() throws IOException, GeneralSecurityException, InvalidFormatException {
33-
try (ByteArrayOutputStream bos = new ByteArrayOutputStream(); POIFSFileSystem fs = new POIFSFileSystem()) {
34-
Workbook wb = new Workbook(bos, "Test", "1.0");
33+
try (ByteArrayOutputStream bos = new ByteArrayOutputStream(); POIFSFileSystem fs = new POIFSFileSystem(); Workbook wb = new Workbook(bos, "Test", "1.0");) {
3534
wb.setGlobalDefaultFont("Arial", 15.5);
3635
Worksheet ws = wb.newWorksheet("Worksheet 1");
3736
ws.value(0, 0, testContent);
38-
wb.finish();
37+
wb.close();
3938
byte[] bytes = bos.toByteArray();
4039
EncryptionInfo info = new EncryptionInfo(EncryptionMode.agile);
4140
// EncryptionInfo info = new EncryptionInfo(EncryptionMode.agile, CipherAlgorithm.aes192, HashAlgorithm.sha384, -1, -1, null);

e2e/src/test/java/org/dhatim/fastexcel/MemoryUsageE2E.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -40,21 +40,21 @@ void writeAndReadFile() throws IOException {
4040
}
4141

4242
private void write(OutputStream out) throws IOException {
43-
Workbook wb = new Workbook(out, "test", "1.0");
44-
for (int s = 0; s < SHEETS; s++) {
45-
Worksheet sheet = wb.newWorksheet("sheet " + s);
46-
for (int r = 0; r < ROWS; r++) {
47-
printProgress("writing", s, r);
48-
for (int c = 0; c < COLS; c++) {
49-
sheet.value(r, c, valueFor(r, c));
50-
}
51-
if (r % FLUSH_EVERY_NR_OR_ROWS == 0) {
52-
sheet.flush();
43+
try(Workbook wb = new Workbook(out, "test", "1.0")){
44+
for (int s = 0; s < SHEETS; s++) {
45+
try(Worksheet sheet = wb.newWorksheet("sheet " + s)){
46+
for (int r = 0; r < ROWS; r++) {
47+
printProgress("writing", s, r);
48+
for (int c = 0; c < COLS; c++) {
49+
sheet.value(r, c, valueFor(r, c));
50+
}
51+
if (r % FLUSH_EVERY_NR_OR_ROWS == 0) {
52+
sheet.flush();
53+
}
54+
}
5355
}
5456
}
55-
sheet.finish();
5657
}
57-
wb.finish();
5858
}
5959

6060
private void read(ReadableWorkbook wb) {

0 commit comments

Comments
 (0)