Implement authorizer override logic#1891
Merged
Merged
Conversation
Add support for authorizer override in HttpServer
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores support for authorizer override when running serverless-offline, ensuring that a provided mock authorizer context (via AUTHORIZER env var or the sls-offline-authorizer-override header) is preserved even when no authorizer is configured (e.g., with noAuth: true). This aligns behavior with pre-v13 releases and addresses the regression described in issue #1826.
Changes:
- Prevent deletion of
event.requestContext.authorizerwhen an override is provided via request header orAUTHORIZERenv var. - Update integration test cleanup to properly remove
AUTHORIZERfrom the environment between tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/integration/override-authorizer/override-authorizer.test.js | Ensures AUTHORIZER is removed via delete after each test to avoid leaking env state. |
| src/events/http/HttpServer.js | Adds authorizer override detection so the authorizer payload isn’t deleted when overrides are in use. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+617
to
+618
| const hasAuthorizerOverride = | ||
| request.headers["sls-offline-authorizer-override"] || env.AUTHORIZER |
Owner
|
Thanks, great job, let's merge it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for authorizer override in HttpServer
Description
Restores the use of an environment variable AUTHORIZER that was broken in v13
Based off the closed PR #1883
Motivation and Context
Fixes #1826
How Has This Been Tested?
Screenshots (if appropriate):