fix: [DHIS2-20478] prevent search when there are errors in the search form fields (#4408)

Author: simonadomnisoru

src/core_modules/capture-core/components/Pages/common/TEIRelationshipsWidget/TeiSearch/SearchOrgUnitSelector/SearchOrgUnitSelectorRefHandler.component.tsx

@@ -13,6 +13,7 @@ export const SearchOrgUnitSelectorRefHandler = (props: Props) => {
     const { innerRef, ...passOnProps } = props;
     return (
         <SearchOrgUnitSelector
+            ref={innerRef}
             {...passOnProps}
         />
     );

src/core_modules/capture-core/components/Pages/common/TEIRelationshipsWidget/TeiSearch/TeiSearchForm/TeiSearchForm.component.tsx

@@ -75,8 +75,8 @@ class SearchFormPlain extends React.Component<Props, State> {
     }
 
     handleSearchAttempt = () => {
-        const isFormValid = this.validateForm();
-        if (!isFormValid) {
+        const { error: validateFormError, isValid: isFormValid } = this.validateForm();
+        if (validateFormError || !isFormValid) {
             this.props.onSearchValidationFailed(this.props.id, this.props.searchGroupId);
             return;
         }
@@ -114,7 +114,7 @@ class SearchFormPlain extends React.Component<Props, State> {
 
         let isValid = this.formInstance.validateFormScrollToFirstFailedField({});
 
-        if (isValid && !this.props.searchGroup.unique) isValid = this.orgUnitSelectorInstance?.validateAndScrollToIfFailed();
+        if (isValid && !this.props.searchGroup.unique) isValid = this.orgUnitSelectorInstance.validateAndScrollToIfFailed();
 
         if (isValid && !this.props.searchGroup.unique) isValid = this.validNumberOfAttributes();
 

src/core_modules/capture-core/components/SearchBox/SearchForm/SearchForm.component.tsx

@@ -155,6 +155,12 @@ const SearchFormIndex = ({
 
             if (isValid) {
                 setError(false);
+
+                const isValidForm = formReference[formId].validateFormScrollToFirstFailedField({});
+                if (!isValidForm) {
+                    return;
+                }
+
                 saveCurrentFormData({ searchScopeType, searchScopeId, formId, formsValues, searchGroupsForSelectedScope });
                 switch (searchScopeType) {
                 case searchScopes.PROGRAM: