refactor: convert remaining Flow files in rules-engine to TypeScript (#4356)

* refactor: convert remaining Flow files in rules-engine to TypeScript

Co-Authored-By: Simona Domnisoru <[email protected]>

* fix: fix TypeScript errors in rulesEffectsProcessor.ts

Co-Authored-By: Simona Domnisoru <[email protected]>

* chore: cleanup

* chore: fix complex typescript errors

* chore: cleanup

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Simona Domnisoru <[email protected]>
Co-authored-by: Simona Domnisoru <[email protected]>

Author: devin-ai-integration[bot]

.eslintrc

@@ -158,7 +158,6 @@
                 "flowtype/no-types-missing-file-annotation": "off",
                 "flowtype/define-flow-type": "off",
                 "flowtype/require-valid-file-annotation": "off",
-                
                 "@typescript-eslint/explicit-module-boundary-types": "off",
                 "@typescript-eslint/explicit-function-return-type": "off",
                 "@typescript-eslint/no-unused-vars": [

packages/rules-engine/.eslintrc

@@ -77,8 +77,6 @@
                 "flowtype/no-types-missing-file-annotation": "off",
                 "flowtype/define-flow-type": "off",
                 "flowtype/require-valid-file-annotation": "off",
-
-                "@typescript-eslint/indent": [2, 4],
                 "@typescript-eslint/explicit-function-return-type": "off",
                 "@typescript-eslint/no-unused-vars": [
                     "error",

packages/rules-engine/d2.config.js

@@ -1,6 +1,6 @@
 module.exports = {
     type: 'lib',
     entryPoints: {
-        lib: 'src/index.js',
+        lib: 'src/index.ts',
     },
 };

packages/rules-engine/src/RulesEngine.js packages/rules-engine/src/RulesEngine.tspackages/rules-engine/src/RulesEngine.js renamed to packages/rules-engine/src/RulesEngine.ts

@@ -1,4 +1,3 @@
-// @flow
 import log from 'loglevel';
 import { VariableService } from './services/VariableService';
 import { ValueProcessor } from './processors/ValueProcessor';
@@ -13,30 +12,30 @@ import type {
     Flag,
 } from './rulesEngine.types';
 import { getRulesEffectsProcessor } from './processors/rulesEffectsProcessor/rulesEffectsProcessor';
-import { effectActions, typeof environmentTypes } from './constants';
+import { effectActions, environmentTypes } from './constants';
 
 export class RulesEngine {
     inputConverter: IConvertInputRulesValue;
     outputConverter: IConvertOutputRulesEffectsValue;
     valueProcessor: ValueProcessor;
     variableService: VariableService;
     dateUtils: IDateUtils;
-    userRoles: Array<string>;
+    userRoles!: Array<string>;
     flags: Flag;
 
     constructor(
         inputConverter: IConvertInputRulesValue,
         outputConverter: IConvertOutputRulesEffectsValue,
         dateUtils: IDateUtils,
-        environment: $Values<environmentTypes>,
+        environment: typeof environmentTypes[keyof typeof environmentTypes],
         flags?: Flag,
     ) {
         this.inputConverter = inputConverter;
         this.outputConverter = outputConverter;
         this.valueProcessor = new ValueProcessor(inputConverter);
         this.variableService = new VariableService(this.valueProcessor.processValue, dateUtils, environment);
         this.dateUtils = dateUtils;
-        this.flags = flags ?? {};
+        this.flags = flags ?? { verbose: false };
     }
 
     /**
@@ -136,7 +135,7 @@ export class RulesEngine {
                         'had no condition specified. Please check rule configuration.');
                 }
 
-                let programRuleEffects = [];
+                let programRuleEffects: any[] = [];
                 if (isProgramRuleExpressionEffective) {
                     programRuleEffects = rule.programRuleActions.map((
                         {
@@ -207,7 +206,6 @@ export class RulesEngine {
             effects,
             dataElements,
             trackedEntityAttributes,
-            // $FlowFixMe[exponential-spread]
             formValues: { ...selectedEntity, ...currentEvent },
             onProcessValue: this.valueProcessor.processValue,
         });

…/src/constants/environmentTypes.const.js …/src/constants/environmentTypes.const.tspackages/rules-engine/src/constants/environmentTypes.const.js renamed to packages/rules-engine/src/constants/environmentTypes.const.ts packages/rules-engine/src/constants/environmentTypes.const.js renamed to packages/rules-engine/src/constants/environmentTypes.const.ts

@@ -1,4 +1,3 @@
-// @flow
 export const environmentTypes = Object.freeze({
     WebClient: 'WebClient',
     AndroidClient: 'AndroidClient',

…es-engine/src/constants/idNames.const.js …es-engine/src/constants/idNames.const.tspackages/rules-engine/src/constants/idNames.const.js renamed to packages/rules-engine/src/constants/idNames.const.ts packages/rules-engine/src/constants/idNames.const.js renamed to packages/rules-engine/src/constants/idNames.const.ts

@@ -1,5 +1,3 @@
-// @flow
-
 export const idNames = {
     DATA_ELEMENT_ID: 'dataElementId',
     TRACKED_ENTITY_ATTRIBUTE_ID: 'trackedEntityAttributeId',

…ages/rules-engine/src/constants/index.js …ages/rules-engine/src/constants/index.tspackages/rules-engine/src/constants/index.js renamed to packages/rules-engine/src/constants/index.ts packages/rules-engine/src/constants/index.js renamed to packages/rules-engine/src/constants/index.ts

@@ -1,4 +1,3 @@
-// @flow
 export { effectActions } from './effectActions.const';
 export { rulesEngineEffectTargetDataTypes } from './targetDataTypes.const';
 export { idNames } from './idNames.const';

…e/src/constants/targetDataTypes.const.js …e/src/constants/targetDataTypes.const.tspackages/rules-engine/src/constants/targetDataTypes.const.js renamed to packages/rules-engine/src/constants/targetDataTypes.const.ts packages/rules-engine/src/constants/targetDataTypes.const.js renamed to packages/rules-engine/src/constants/targetDataTypes.const.ts

@@ -1,5 +1,3 @@
-// @flow
-
 export const rulesEngineEffectTargetDataTypes = {
     DATA_ELEMENT: 'dataElement',
     TRACKED_ENTITY_ATTRIBUTE: 'trackedEntityAttribute',

…s-engine/src/constants/typeKeys.const.js …s-engine/src/constants/typeKeys.const.tspackages/rules-engine/src/constants/typeKeys.const.js renamed to packages/rules-engine/src/constants/typeKeys.const.ts packages/rules-engine/src/constants/typeKeys.const.js renamed to packages/rules-engine/src/constants/typeKeys.const.ts

@@ -1,4 +1,3 @@
-// @flow
 export const typeKeys = {
     TEXT: 'TEXT',
     MULTI_TEXT: 'MULTI_TEXT',

…constants/typeToInterfaceFnName.const.js …constants/typeToInterfaceFnName.const.tspackages/rules-engine/src/constants/typeToInterfaceFnName.const.js renamed to packages/rules-engine/src/constants/typeToInterfaceFnName.const.ts packages/rules-engine/src/constants/typeToInterfaceFnName.const.js renamed to packages/rules-engine/src/constants/typeToInterfaceFnName.const.ts

@@ -1,4 +1,3 @@
-// @flow
 import { typeKeys } from './typeKeys.const';
 
 export const mapTypeToInterfaceFnName = {