test: assert the query count does not grow, instead of exact equality

dataElementCountDoesNotScaleQueryCount compares a metadata export with 3
data elements against one with 8 and asserted the two select counts were
equal. With the cache changes in this branch the second export legitimately
issues FEWER selects (21 vs 22): what the first export loaded is still
cached during the second. Assert the invariant the test name and comment
state - the count must not grow - so the test keeps catching a
reintroduced N+1 without failing on a cache improvement.

AI Assisted

Author: netroms

dhis-2/dhis-test-integration/src/test/java/org/hisp/dhis/dxf2/metadata/DataSetMetadataExportServiceQueryCountTest.java

@@ -115,10 +115,15 @@ void dataElementCountDoesNotScaleQueryCount() {
     // DataElement / DataSetElement loads are batched into a single query, so the select count must
     // not grow with the number of data elements. If it does, the N+1 has been reintroduced (e.g. by
     // iterating DataSet.getDataElements() or DataElement.getCategoryCombos() lazily).
-    assertEquals(
-        baseline,
-        withMoreDataElements,
-        "adding data elements must not increase the number of SQL selects");
+    // The count may legitimately DROP between the two measurements: whatever the first export
+    // loaded can still be served from the second level cache during the second one, so this
+    // asserts the invariant the test name states (no growth) rather than exact equality.
+    assertTrue(
+        withMoreDataElements <= baseline,
+        "adding data elements must not increase the number of SQL selects: "
+            + baseline
+            + " -> "
+            + withMoreDataElements);
   }
 
   @Test