Merge pull request #3 from dhruvan2006/github-actions

Add release and tests action

Author: dhruvan2006

.github/workflows/release.yml

@@ -0,0 +1,51 @@
+name: Release
+
+on:
+  push:
+    tags:
+      - "v*"
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Set up Python
+      uses: actions/setup-python@v5
+      with:
+        python-version: "3.x"
+
+    - name: Install pypa/build
+      run: python3 -m pip install build --user
+
+    - name: Build a binary wheel and a source tarball
+      run: python3 -m build
+
+    - name: Store the distribution packages
+      uses: actions/upload-artifact@v4
+      with:
+        name: python-package-distributions
+        path: dist/
+
+  publish-to-pypi:
+    name: >-
+      Publish Python distribution to PyPI
+    needs:
+      - build
+    runs-on: ubuntu-latest
+    environment:
+      name: pypi
+      url: https://pypi.org/p/ocfinance
+    permissions:
+      id-token: write  # IMPORTANT: mandatory for trusted publishing
+
+    steps:
+    - name: Download all the dists
+      uses: actions/download-artifact@v4
+      with:
+        name: python-package-distributions
+        path: dist/
+    - name: Publish distribution to PyPI
+      uses: pypa/gh-action-pypi-publish@release/v1

.github/workflows/tests.yml

@@ -0,0 +1,25 @@
+name: Tests
+
+on:
+  push:
+    branches: ["main"]
+  pull_request:
+    branches: ["main"]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.x"
+      - name: Install dependencies
+        run: |
+          pip install --upgrade pip
+          pip install -r requirements.txt
+          pip install pytest
+      - name: Run tests
+        run: pytest

ocfinance/scraper/cryptoquant.py

@@ -7,6 +7,11 @@
 CRYPTOQUANT_URL = "https://cryptoquant.com/"
 
 def _download(url, **kwargs):
+    email = kwargs.get('email')
+    password = kwargs.get('password')
+    if not email or not password:
+        raise TypeError("Email and/or password hasn't been passed")
+
     splits = urlparse(url).path.split('/')
     id = splits[-1]
 
@@ -17,10 +22,6 @@ def _download(url, **kwargs):
     proxy = kwargs.get('proxy', None)
     driver = _get_driver(proxy=proxy)
 
-    email = kwargs.get('email')
-    password = kwargs.get('password')
-    if not email or not password:
-        raise TypeError("Email and/or password hasn't been passed")
     data = _get_json(driver, id, email, password)
 
     columns = data['data']['result']['columns']

tests/test_bitbo.py

@@ -60,8 +60,9 @@ def test_download_data(monkeypatch):
     result_df = _download('test_url')
 
     pd.testing.assert_frame_equal(result_df, expected_df)
-    
 
+
+@pytest.mark.skipif(not sbr_webdriver, reason="Skipping Bitbo integration tests: SBR_WEBDRIVER not provided.")
 @pytest.mark.parametrize("url, expected_columns", [
     (
         "https://charts.bitbo.io/cycle-repeat/",

tests/test_download.py

@@ -31,7 +31,7 @@ def test_download_valid_urls(url, expected_data, provider):
 
 def test_download_invalid_url():
     invalid_url = "https://unknownsource.com/some_data"
-    with pytest.raises(ValueError, match="URL does not match any known source"):
+    with pytest.raises(ValueError, match="Unsupported source"):
         download(invalid_url)