Add import guard for legacy models, fix tests for 3.14

Author: dhvcc

rss_parser/models/legacy/__init__.py

@@ -4,9 +4,13 @@
 Some types and validation may be a bit custom to account for broken standards in some RSS feeds.
 """
 
+import sys
 from json import loads
 from typing import TYPE_CHECKING
 
+if sys.version_info >= (3, 14):
+    raise ImportError("Legacy models are not supported in Python 3.14 and above")
+
 from rss_parser.models.legacy.pydantic_proxy import import_v1_pydantic
 from rss_parser.models.legacy.utils import camel_case
 

tests/test_parsing.py

@@ -1,18 +1,29 @@
+import sys
 from typing import Type
 
 import pytest
 
 from rss_parser import AtomParser, BaseParser, RSSParser
-from rss_parser.models.legacy.atom import Atom as LegacyAtom
-from rss_parser.models.legacy.rss import RSS as LegacyRSS
 
+if sys.version_info < (3, 14):
+    from rss_parser.models.legacy.atom import Atom as LegacyAtom
+    from rss_parser.models.legacy.rss import RSS as LegacyRSS
 
-class LegacyRSSParser(RSSParser):
-    schema = LegacyRSS
+    class LegacyRSSParser(RSSParser):
+        schema = LegacyRSS
 
+    class LegacyAtomParser(AtomParser):
+        schema = LegacyAtom
 
-class LegacyAtomParser(AtomParser):
-    schema = LegacyAtom
+    rss_parser_list = [RSSParser, LegacyRSSParser]
+    rss_ids = ["rss-v2", "rss-legacy"]
+    atom_parser_list = [AtomParser, LegacyAtomParser]
+    atom_ids = ["atom-v2", "atom-legacy"]
+else:
+    rss_parser_list = [RSSParser]
+    rss_ids = ["rss-v2"]
+    atom_parser_list = [AtomParser]
+    atom_ids = ["atom-v2"]
 
 
 class DataHelper:
@@ -32,14 +43,14 @@ def compare_parsing(sample_and_result, parser: Type[BaseParser]):
 
 RSS_PARSERS = pytest.mark.parametrize(
     "parser_cls",
-    [RSSParser, LegacyRSSParser],
-    ids=["rss-v2", "rss-legacy"],
+    rss_parser_list,
+    ids=rss_ids,
 )
 
 ATOM_PARSERS = pytest.mark.parametrize(
     "parser_cls",
-    [AtomParser, LegacyAtomParser],
-    ids=["atom-v2", "atom-legacy"],
+    atom_parser_list,
+    ids=atom_ids,
 )
 
 
@@ -74,3 +85,10 @@ class TestAtom:
     @ATOM_PARSERS
     def test_parses_all_atom_samples(self, sample_and_result, parser_cls):
         DataHelper.compare_parsing(sample_and_result, parser=parser_cls)
+
+
+class TestLegacyImportError:
+    @pytest.mark.skipif(sys.version_info < (3, 14), reason="Legacy models still work in Python 3.13 and below")
+    def test_legacy_import_error(self):
+        with pytest.raises(ImportError):
+            from rss_parser.models.legacy import XMLBaseModel  # noqa: F401, PLC0415