Skip to content

Commit b95636b

Browse files
authored
PHP 8.4 (#276)
* PHP 8.4 * dep bumps
1 parent 6a8a4b8 commit b95636b

File tree

4 files changed

+8
-9
lines changed

4 files changed

+8
-9
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@ jobs:
1313
fail-fast: false
1414
matrix:
1515
operating-system: [ubuntu-latest]
16-
php-versions: ["8.0", "8.1", "8.2", "8.3"]
16+
php-versions: ["8.0", "8.1", "8.2", "8.3", "8.4"]
1717
composer-args: ["", "--prefer-lowest"]
1818
runs-on: ${{ matrix.operating-system }}
1919
steps:
2020
- name: Checkout
2121
uses: actions/checkout@v4
2222
- name: Setup PHP
23-
uses: shivammathur/setup-php@2.30.2
23+
uses: shivammathur/setup-php@2.33.0
2424
with:
2525
php-version: ${{ matrix.php-versions }}
2626
extensions: mbstring

composer.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"license": "BSD-3-Clause",
1111
"prefer-stable": true,
1212
"require": {
13-
"php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
13+
"php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
1414
"diablomedia/zendframework1-validate": "^1.0.5",
1515
"diablomedia/zendframework1-uri": "^1.0.5"
1616
},
@@ -26,8 +26,8 @@
2626
},
2727
"require-dev": {
2828
"phpunit/phpunit": "^9.6.19 || ^10.5.18",
29-
"phpstan/phpstan": "1.10.67",
30-
"friendsofphp/php-cs-fixer": "3.54.0",
29+
"phpstan/phpstan": "2.1.16",
30+
"friendsofphp/php-cs-fixer": "3.75.0",
3131
"maglnet/composer-require-checker": "^3.0.0",
3232
"phpro/grumphp-shim": "^2.0.0"
3333
},

phpstan.neon

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
parameters:
2-
checkMissingIterableValueType: false
32
level: 8
3+
treatPhpDocTypesAsCertain: false
44
paths:
55
- ./
66
excludePaths:
77
- %rootDir%/../../../vendor/*
88
- %rootDir%/../../../tests/*
99
ignoreErrors:
10+
-
11+
identifier: missingType.iterableValue

src/Zend/Validate/Sitemap/Changefreq.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,6 @@ public function isValid($value)
7676
}
7777

7878
$this->_setValue($value);
79-
if (!is_string($value)) {
80-
return false;
81-
}
8279

8380
if (!in_array($value, $this->_changeFreqs, true)) {
8481
$this->_error(self::NOT_VALID);

0 commit comments

Comments
 (0)