Skip to content
This repository was archived by the owner on May 29, 2023. It is now read-only.

Commit 1fbeabd

Browse files
committed
[eslint config] [*] [breaking] [deps] update eslint, eslint-plugin-import
1 parent fd68fdb commit 1fbeabd

File tree

3 files changed

+28
-8
lines changed

3 files changed

+28
-8
lines changed

packages/eslint-config-airbnb-base/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,16 @@
5151
"babel-preset-airbnb": "^2.4.0",
5252
"babel-tape-runner": "^2.0.1",
5353
"editorconfig-tools": "^0.1.1",
54-
"eslint": "^4.18.0",
54+
"eslint": "^4.18.1",
5555
"eslint-find-rules": "^3.2.0",
56-
"eslint-plugin-import": "^2.8.0",
56+
"eslint-plugin-import": "^2.9.0",
5757
"in-publish": "^2.0.0",
5858
"safe-publish-latest": "^1.1.1",
5959
"tape": "^4.9.0"
6060
},
6161
"peerDependencies": {
62-
"eslint": "^4.16.0",
63-
"eslint-plugin-import": "^2.8.0"
62+
"eslint": "^4.18.1",
63+
"eslint-plugin-import": "^2.9.0"
6464
},
6565
"engines": {
6666
"node": ">= 4"

packages/eslint-config-airbnb-base/rules/imports.js

+20
Original file line numberDiff line numberDiff line change
@@ -211,5 +211,25 @@ module.exports = {
211211
// https://github.com/benmosher/eslint-plugin-import/blob/98acd6afd04dcb6920b81330114e146dc8532ea4/docs/rules/exports-last.md
212212
// TODO: enable?
213213
'import/exports-last': 'off',
214+
215+
// Reports when named exports are not grouped together in a single export declaration
216+
// or when multiple assignments to CommonJS module.exports or exports object are present
217+
// in a single file.
218+
// https://github.com/benmosher/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/group-exports.md
219+
'import/group-exports': 'off',
220+
221+
// forbid default exports. this is a terrible rule, do not use it.
222+
// https://github.com/benmosher/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/no-default-export.md
223+
'import/no-default-export': 'off',
224+
225+
// Forbid a module from importing itself
226+
// https://github.com/benmosher/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/no-self-import.md
227+
// TODO: enable
228+
'import/no-self-import': 'off',
229+
230+
// Ensures that there are no useless path segments
231+
// https://github.com/benmosher/eslint-plugin-import/issues/1032
232+
// TODO: enable
233+
'import/no-useless-path-segments': 'off',
214234
},
215235
};

packages/eslint-config-airbnb/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@
5454
"babel-preset-airbnb": "^2.4.0",
5555
"babel-tape-runner": "^2.0.1",
5656
"editorconfig-tools": "^0.1.1",
57-
"eslint": "^4.18.0",
57+
"eslint": "^4.18.1",
5858
"eslint-find-rules": "^3.2.0",
59-
"eslint-plugin-import": "^2.8.0",
59+
"eslint-plugin-import": "^2.9.0",
6060
"eslint-plugin-jsx-a11y": "^6.0.3",
6161
"eslint-plugin-react": "^7.7.0",
6262
"in-publish": "^2.0.0",
@@ -65,8 +65,8 @@
6565
"tape": "^4.9.0"
6666
},
6767
"peerDependencies": {
68-
"eslint": "^4.18.0",
69-
"eslint-plugin-import": "^2.8.0",
68+
"eslint": "^4.18.1",
69+
"eslint-plugin-import": "^2.9.0",
7070
"eslint-plugin-jsx-a11y": "^6.0.3",
7171
"eslint-plugin-react": "^7.7.0"
7272
},

0 commit comments

Comments
 (0)