Skip to content
This repository was archived by the owner on May 29, 2023. It is now read-only.

Commit 8daa4e7

Browse files
committed
[eslint config] [base] Add comments on new import rules.
1 parent b59bfff commit 8daa4e7

File tree

1 file changed

+3
-2
lines changed
  • packages/eslint-config-airbnb-base/rules

1 file changed

+3
-2
lines changed

packages/eslint-config-airbnb-base/rules/imports.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,9 @@ module.exports = {
155155
allow: [],
156156
}],
157157

158-
// Warn if a module could be mistakenly parsed as a script by a consumer leveraging Unambiguous
159-
// JavaScript Grammar
158+
// Warn if a module could be mistakenly parsed as a script by a consumer leveraging Unambiguous JavaScript Grammar
160159
// https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/unambiguous.md
160+
// this should not be enabled until this proposal has at least been *presented* to TC39. At the moment, it's not a thing.
161161
'import/unambiguous': 'off',
162162

163163
// Forbid Webpack loader syntax in imports
@@ -166,6 +166,7 @@ module.exports = {
166166

167167
// Prevent unassigned imports
168168
// https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unassigned-import.md
169+
// importing for side effects is perfectly acceptable, if you need side effects.
169170
'import/no-unassigned-import': 'off',
170171
},
171172
};

0 commit comments

Comments
 (0)