Skip to content

Split initialization of sms provider and hlr lookups provider #24

Open
@Spring3

Description

@Spring3

I needed only HLR lookups provider, so I called getProviders() function to get one, but the thing is that it also initializes SmsApiProvider inside and hence requires some envs to configure that one.

So I needed to use random values as stubs to avoid assertion error when it tried to initialize SmsApiProvider, but this polluted the env file with some unused stubs.

I think providers should be initialized separately and the function should be split in two

UPD: for backward compatibility you can keep getProviders function that will call those 2 new functions after a separation of concerns

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions