Skip to content

Commit ce6f1e1

Browse files
authored
fix: delete broken task-dump examples and fix CI to catch example failures (#180)
The `task_dump` module was removed but 4 examples (long_sleep, completing_task, cancelled_task, debug_timing) and 1 bench (poll_overhead) that depended on it were left behind. These compiled fine in the default CI because: 1. `cargo build` didn't use `--all-features` or `--all-targets`, so feature-gated examples were never compiled 2. `cargo clippy` didn't use `--all-targets` or `--all-features`, so examples and feature-gated code were not linted Only the nightly stress test (which uses `--all-features`) caught the breakage. Changes: - Delete 4 broken task-dump examples and 1 broken bench - Remove the `task-dump` feature from Cargo.toml and README - Build action: `cargo build` → `cargo build --all-targets --all-features` - Build action: `cargo test` → `cargo test --all-features` - Clippy: `cargo clippy --workspace` → `cargo clippy --all-targets --all-features`
1 parent 58ecb0d commit ce6f1e1

10 files changed

Lines changed: 3 additions & 309 deletions

File tree

.github/actions/rust-build/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ runs:
2020
if [ "${{ inputs.toolchain }}" != stable ]; then
2121
rm -fv Cargo.lock
2222
fi
23-
cargo build
23+
cargo build --all-targets --all-features
2424
- name: Enable perf_event_open and kallsyms for tests
2525
shell: bash
2626
run: |
@@ -33,4 +33,4 @@ runs:
3333
run: |
3434
# Raise locked-memory limit for large perf ring buffers
3535
sudo prlimit --pid $$ --memlock=unlimited:unlimited
36-
cargo test
36+
cargo test --all-features

.github/workflows/format.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@ jobs:
2525
shell: bash
2626
env:
2727
RUSTFLAGS: "--cfg tokio_unstable"
28-
run: cargo clippy --workspace -- -D warnings
28+
run: cargo clippy --all-targets --all-features -- -D warnings

Cargo.lock

Lines changed: 0 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dial9-tokio-telemetry/Cargo.toml

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ metrique = { version = "0.1.23", features = ["local-format"] }
4242
[features]
4343
analysis = []
4444
cpu-profiling = ["dep:dial9-perf-self-profile"]
45-
task-dump = ["tokio/taskdump"]
4645
worker-s3 = ["dep:aws-sdk-s3-transfer-manager", "dep:aws-sdk-s3", "dep:aws-config", "dep:time"]
4746

4847
[dev-dependencies]
@@ -67,11 +66,6 @@ uuid = { version = "1", features = ["v4"] }
6766
dial9-tokio-telemetry = { path = ".", features = ["cpu-profiling", "worker-s3", "analysis"] }
6867
nix = { version = "0.29", features = ["process"] }
6968

70-
[[bench]]
71-
name = "poll_overhead"
72-
harness = false
73-
required-features = ["task-dump"]
74-
7569
[[bench]]
7670
name = "overhead_bench"
7771
harness = false
@@ -80,22 +74,6 @@ harness = false
8074
name = "e2e_workload"
8175
harness = false
8276

83-
[[example]]
84-
name = "long_sleep"
85-
required-features = ["task-dump"]
86-
87-
[[example]]
88-
name = "completing_task"
89-
required-features = ["task-dump"]
90-
91-
[[example]]
92-
name = "cancelled_task"
93-
required-features = ["task-dump"]
94-
95-
[[example]]
96-
name = "debug_timing"
97-
required-features = ["task-dump"]
98-
9977
[[example]]
10078
name = "blocking_sleep"
10179
required-features = ["cpu-profiling"]

dial9-tokio-telemetry/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,6 @@ See [TRACE_ANALYSIS_GUIDE.md](/dial9-tokio-telemetry/TRACE_ANALYSIS_GUIDE.md) fo
221221
## Features
222222

223223
- **`cpu-profiling`** — Linux only. Enables `perf_event_open`-based CPU sampling and scheduler event capture via `dial9-perf-self-profile`.
224-
- **`task-dump`** — Enables Tokio's `taskdump` feature for async stack traces. Required for the `long_sleep`, `completing_task`, `cancelled_task`, and `debug_timing` examples.
225224
- **`worker-s3`** — Enables S3 upload support. Adds `aws-sdk-s3`, `aws-sdk-s3-transfer-manager`, `aws-config`, and `flate2`.
226225

227226
## S3 upload

dial9-tokio-telemetry/benches/poll_overhead.rs

Lines changed: 0 additions & 64 deletions
This file was deleted.

dial9-tokio-telemetry/examples/cancelled_task.rs

Lines changed: 0 additions & 54 deletions
This file was deleted.

dial9-tokio-telemetry/examples/completing_task.rs

Lines changed: 0 additions & 35 deletions
This file was deleted.

dial9-tokio-telemetry/examples/debug_timing.rs

Lines changed: 0 additions & 55 deletions
This file was deleted.

dial9-tokio-telemetry/examples/long_sleep.rs

Lines changed: 0 additions & 41 deletions
This file was deleted.

0 commit comments

Comments
 (0)