Skip to content

Commit 01a5146

Browse files
feat(callbox): NO-JIRA style improvements (#705)
1 parent 22d7935 commit 01a5146

File tree

9 files changed

+80
-53
lines changed

9 files changed

+80
-53
lines changed

packages/dialtone-css/lib/build/less/recipes/callbox.less

Lines changed: 23 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,26 @@
22
padding: 0;
33
color: var(--dt-color-foreground-primary);
44
background-color: var(--dt-color-surface-primary);
5-
border-radius: var(--dt-size-radius-300);
5+
border-radius: var(--dt-size-radius-400);
66
}
77

88
.d-recipe-callbox__video {
99
display: flex;
10-
margin-bottom: var(--dt-space-300-negative);
1110
overflow: clip;
12-
border-radius: var(--dt-size-radius-200) var(--dt-size-radius-200) 0 0;
11+
border-radius: var(--dt-size-radius-400) var(--dt-size-radius-400) 0 0;
1312
}
1413

1514
.d-recipe-callbox__main-content {
1615
align-items: stretch;
1716
padding: 0;
1817
border: var(--dt-size-border-100) solid transparent;
19-
border-radius: var(--dt-size-radius-300);
18+
border-radius: var(--dt-size-radius-400);
19+
20+
.d-recipe-callbox__video + & {
21+
border-start-start-radius: 0;
22+
border-start-end-radius: 0;
23+
border-block-start-width: 0;
24+
}
2025

2126
&.d-recipe-callbox__border-default {
2227
border-color: var(--dt-color-border-default);
@@ -29,29 +34,32 @@
2934

3035
&.d-recipe-callbox__border-critical {
3136
background: radial-gradient(var(--dt-color-surface-primary), var(--dt-color-surface-primary)) padding-box,
32-
radial-gradient(circle, #E7301D, #F78B23) border-box;
37+
radial-gradient(circle, var(--dt-color-border-critical-strong), var(--dt-color-border-critical)) border-box;
3338
}
3439
}
3540

41+
.d-recipe-callbox__avatar {
42+
margin-inline-start: var(--dt-space-200);
43+
}
44+
3645
.d-recipe-callbox__main-content-top {
3746
display: flex;
47+
gap: var(--dt-space-350);
3848
align-items: center;
39-
padding: var(--dt-space-350) var(--dt-space-400);
49+
padding: var(--dt-space-400) var(--dt-space-350) var(--dt-space-350) var(--dt-space-400);
4050
}
4151

4252
.d-recipe-callbox__main-content-bottom {
43-
border-top: 1px solid var(--dt-color-border-subtle);
44-
}
45-
46-
.d-recipe-callbox__avatar {
47-
margin-right: var(--dt-space-400);
53+
border-top: var(--dt-size-border-100) solid var(--dt-color-border-subtle);
4854
}
4955

5056
.d-recipe-callbox__content {
5157
display: flex;
5258
flex: 1 0 auto;
5359
flex-direction: column;
60+
gap: var(--dt-space-300);
5461
min-width: 0;
62+
padding-inline-start: var(--dt-space-200);
5563
}
5664

5765
.d-recipe-callbox__content-title {
@@ -60,14 +68,13 @@
6068
padding: 0;
6169
overflow: clip;
6270
color: var(--dt-color-foreground-primary);
63-
font-weight: var(--dt-font-weight-bold);
64-
line-height: normal;
71+
font: var(--dt-typography-headline-md);
72+
line-height: var(--dt-font-line-height-100);
6573
white-space: nowrap;
6674
text-align: left;
6775
text-overflow: ellipsis;
6876
background-color: var(--dt-color-surface-primary);
6977
border: none;
70-
user-select: text;
7178
}
7279

7380
.d-recipe-callbox__content-badge {
@@ -80,8 +87,7 @@
8087
padding: 0;
8188
overflow: hidden;
8289
color: var(--dt-color-foreground-tertiary);
83-
font-size: var(--dt-font-size-100);
84-
line-height: normal;
90+
font: var(--dt-typography-body-sm-compact);
8591
}
8692

8793
.d-recipe-callbox__right {
@@ -101,6 +107,7 @@
101107
}
102108

103109
&:hover, &:active {
110+
color: var(--dt-color-link-primary-hover);
104111
text-decoration: underline;
105112
}
106113
}

packages/dialtone-vue2/recipes/leftbar/callbox/callbox.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ import { DtRecipeCallbox } from '@dialpad/dialtone-vue';
4444
>
4545
<template #icon>
4646
<dt-icon
47-
name="dialpad-ai-color"
47+
name="dialpad-sparkle"
4848
size="400"
4949
/>
5050
</template>

packages/dialtone-vue2/recipes/leftbar/callbox/callbox.stories.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export const argTypesData = {
1414
};
1515

1616
const decorator = () => ({
17-
template: `<div style="background-color: var(--dt-theme-sidebar-color-background)" class="d-wmx264 d-p8"><story />
17+
template: `<div style="background-color: var(--dt-theme-sidebar-color-background)" class="d-wmx332 d-p16"><story />
1818
</div>`,
1919
});
2020

packages/dialtone-vue2/recipes/leftbar/callbox/callbox.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,10 @@
3939
<div class="d-recipe-callbox__content">
4040
<component
4141
:is="clickable ? 'button' : 'span'"
42+
v-dt-tooltip="title"
4243
data-qa="dt-recipe-callbox__title"
4344
class="d-recipe-callbox__content-title"
45+
tabindex="0"
4446
@click="handleClick"
4547
>
4648
{{ title }}

packages/dialtone-vue2/recipes/leftbar/callbox/callbox_variants.story.vue

Lines changed: 25 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
border-color="ai"
99
>
1010
<template #subtitle>
11-
<span>06:01</span>
11+
<span class="d-fvn-tabular">06:01</span>
1212
</template>
1313
<template #right>
1414
<dt-button
@@ -17,7 +17,7 @@
1717
importance="clear"
1818
>
1919
<template #icon>
20-
<dt-icon-dialpad-ai-color size="400" />
20+
<dt-icon-dialpad-sparkle size="400" />
2121
</template>
2222
</dt-button>
2323
<dt-button
@@ -37,7 +37,7 @@
3737
avatar-seed="1 Participant"
3838
>
3939
<template #subtitle>
40-
<span>06:01</span>
40+
<span class="d-fvn-tabular">06:01</span>
4141
</template>
4242
<template #right>
4343
<dt-button
@@ -82,7 +82,7 @@
8282
>
8383
</template>
8484
<template #subtitle>
85-
<span>06:01</span>
85+
<span class="d-fvn-tabular">06:01</span>
8686
</template>
8787
<template #right>
8888
<dt-button
@@ -124,7 +124,7 @@
124124
border-color="ai"
125125
>
126126
<template #subtitle>
127-
<span>06:01</span>
127+
<span class="d-fvn-tabular">06:01</span>
128128
</template>
129129
<template #right>
130130
<dt-button
@@ -133,7 +133,7 @@
133133
importance="clear"
134134
>
135135
<template #icon>
136-
<dt-icon-dialpad-ai-color size="400" />
136+
<dt-icon-dialpad-sparkle size="400" />
137137
</template>
138138
</dt-button>
139139
<dt-button
@@ -161,7 +161,7 @@
161161
class="d-ai-center"
162162
>
163163
<dt-icon-share-screen size="100" />
164-
<span>06:01</span>
164+
<span class="d-fvn-tabular">06:01</span>
165165
</dt-stack>
166166
</template>
167167
<template #right>
@@ -181,7 +181,7 @@
181181
importance="clear"
182182
>
183183
<template #icon>
184-
<dt-icon-dialpad-ai-color size="400" />
184+
<dt-icon-dialpad-sparkle size="400" />
185185
</template>
186186
</dt-button>
187187
<dt-button
@@ -247,8 +247,11 @@
247247
/>
248248
<span>3</span>
249249
</dt-stack>
250-
<span class="d-fs-300">
251-
250+
<span
251+
class="d-body--sm-compact"
252+
aria-hidden="true"
253+
>
254+
&bull;
252255
</span>
253256
<dt-stack
254257
direction="row"
@@ -300,7 +303,7 @@
300303
class="d-ai-center"
301304
>
302305
<dt-icon-share-screen size="100" />
303-
<span>06:01</span>
306+
<span class="d-fvn-tabular">06:01</span>
304307
</dt-stack>
305308
</template>
306309
<template #right>
@@ -310,7 +313,7 @@
310313
importance="clear"
311314
>
312315
<template #icon>
313-
<dt-icon-dialpad-ai-color size="400" />
316+
<dt-icon-dialpad-sparkle size="400" />
314317
</template>
315318
</dt-button>
316319
<dt-button
@@ -334,9 +337,14 @@
334337
<dt-stack
335338
direction="row"
336339
gap="400"
340+
class="d-pl2"
337341
>
338-
<dt-icon-share-screen size="400" />
339-
<span class="d-fs-100">Sharing screen</span>
342+
<dt-stack
343+
class="d-ai-center d-w24"
344+
>
345+
<dt-icon-share-screen size="400" />
346+
</dt-stack>
347+
<span class="d-body--sm-compact">Sharing screen</span>
340348
</dt-stack>
341349
</template>
342350
<template #right>
@@ -367,7 +375,7 @@
367375
class="d-ai-center"
368376
>
369377
<dt-icon-share-screen size="100" />
370-
<span>06:01</span>
378+
<span class="d-fvn-tabular">06:01</span>
371379
</dt-stack>
372380
</template>
373381
<template #right>
@@ -390,7 +398,7 @@
390398
import DtRecipeCallbox from './callbox.vue';
391399
import DtButton from '@/components/button/button.vue';
392400
import {
393-
DtIconDialpadAiColor,
401+
DtIconDialpadSparkle,
394402
DtIconPhoneHangUp,
395403
DtIconShareScreen,
396404
DtIconStopFilled,
@@ -410,7 +418,7 @@ export default {
410418
DtItemLayout,
411419
DtButton,
412420
DtRecipeCallbox,
413-
DtIconDialpadAiColor,
421+
DtIconDialpadSparkle,
414422
DtIconPhoneHangUp,
415423
DtIconShareScreen,
416424
DtIconStopFilled,

packages/dialtone-vue3/recipes/leftbar/callbox/callbox.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ import { DtRecipeCallbox } from '@dialpad/dialtone-vue';
4444
>
4545
<template #icon>
4646
<dt-icon
47-
name="dialpad-ai-color"
47+
name="dialpad-sparkle"
4848
size="400"
4949
/>
5050
</template>

packages/dialtone-vue3/recipes/leftbar/callbox/callbox.stories.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export const argTypesData = {
1414
};
1515

1616
const decorator = () => ({
17-
template: `<div style="background-color: var(--dt-theme-sidebar-color-background)" class="d-wmx264 d-p8"><story />
17+
template: `<div style="background-color: var(--dt-theme-sidebar-color-background)" class="d-wmx332 d-p16"><story />
1818
</div>`,
1919
});
2020

packages/dialtone-vue3/recipes/leftbar/callbox/callbox.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,10 @@
4040
<div class="d-recipe-callbox__content">
4141
<component
4242
:is="clickable ? 'button' : 'span'"
43+
v-dt-tooltip="title"
4344
data-qa="dt-recipe-callbox__title"
4445
class="d-recipe-callbox__content-title"
46+
tabindex="0"
4547
@click="handleClick"
4648
>
4749
{{ title }}

0 commit comments

Comments
 (0)